lts.conf doesn't get transferred to the clients

Bug #238010 reported by Alkis Georgopoulos
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ltsp (Ubuntu)
Fix Released
Undecided
Alkis Georgopoulos

Bug Description

Ubuntu Hardy 8.04, ltsp-server 5.0.40~bzr20080212-0ubuntu7

It's actually 2 bugs = 2 lines that need to be changed in usr/share/initramfs-tools/scripts/ltsp_nbd

First, in line
tftpath=$(echo ${filename%/*}|tr -d '"')
if filename=ltsp3.pxe with no path,
tftpath becomes ltsp3.pxe instead of / or ./

Second, in the next line,
(echo "get ${tftpath}/lts.conf"|tftp ${ROOTSERVER} >/dev/null 2>&1)
I suggest it would be changed to something like
(echo -e "binary\nget ${tftpath}/lts.conf"|tftp ${ROOTSERVER} >/dev/null 2>&1)
because at least 2 tftp servers do not support netascii transfer mode
(dnsmasq < 2.42 and the virtualbox 1.6.2 embedded tftp server when using NAT networking)

Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

1) Title wrong, I meant lts.conf doesn't get transferred to the clients
2) tftpath should probably be empty (neither / nor ./) if filename does not contain any slashes.

Revision history for this message
Scott Balneaves (sbalneav) wrote :

I agree with 1, and will look into it.

I disagree with point 2. lts.conf is a text file, we shouldn't be switching to binary mode to transfer it. If some tftp servers don't support text mode, that's bugs with them that should be fixed.

Changed in ltsp:
assignee: nobody → sbalneav
status: New → Confirmed
Revision history for this message
Vagrant Cascadian (vagrantc) wrote : Re: [Bug 238010] Re: lts.conf doesn't get transferred to the chroot

On Sun, Nov 16, 2008 at 05:42:24AM -0000, Scott Balneaves wrote:
> lts.conf is a text file, we shouldn't be switching to binary mode to transfer
> it.

why not? what problem does it really cause to switch to a mode that will
reliably and consistantly work across all tftp servers?

> If some tftp servers don't support text mode, that's bugs with them that
> should be fixed.

maybe, though is text mode required to be implemented in tftp standards?

live well,
  vagrant

summary: - lts.conf doesn't get transferred to the chroot
+ lts.conf doesn't get transferred to the clients
Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

I've uploaded a fix for the first part in http://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltsp-trunk/revision/1675

The second part isn't really important anymore, dnsmasq 2.41 is ancient now, and vbox doesn't need bridging anymore, making NAT less frequent. So I kept the netascii transfer.

Changed in ltsp (Ubuntu):
assignee: Scott Balneaves (sbalneav) → Alkis Georgopoulos (alkisg)
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ltsp - 5.2.1-0ubuntu1

---------------
ltsp (5.2.1-0ubuntu1) lucid; urgency=low

  * New upstream bugfix release (5.2.1)
   * Fix plymouth and VT switch in Ubuntu
   * Reduce and improve VT switching
   * Disable LOCALDEV for fat clients
   * Fix ConsoleKit/PolicyKit support for Fat clients
   * Don't quote the clientid in udhcp (fix Windows DHCP)
   * Fix VT switching (LP: #533964)
   * Set HOME and SHELL env variables for shell sessions
   * Allow clientid for udhcpc to be passed as parameter (LP: #505916)
   * Fix call to unavailable functions in init scripts
   * Quiet down the scripts output and improve readability
   * Fix /etc/mtab so mountall doesn't complain
   * Hide reboot and shutdown menus for Fat clients
   * Fix screensaver for Fat clients
   * Cleanup ltsp-update-sshkeys usage
   * Properly separate tftppath in ltsp_nbd (LP: #238010)
 -- Stephane Graber <email address hidden> Sun, 14 Mar 2010 10:38:40 -0400

Changed in ltsp (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

The KVM TFTP server also complains about "unsupported mode" when doing text transfers, so I've switched to binary mode in http://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltsp-trunk/revision/2774.

It might be a bug in other packages, but it's impossible for LTSP developers to send patches to all TFTP servers that don't support text transfers. I'm not even sure if it's mandated from the TFTP protocol or not.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.