Entertainer Media Center

Endless scrolling on lyrics

Bug #224699 reported by Jamie Bennett
2
Affects Status Importance Assigned to Milestone
Entertainer Media Center
Fix Released
High
Matt Layman
Entertainer Media Center 0.1-release

Bug Description

** IMPORTED FROM GOOGLE CODE **

Reported by dundee.michael, Feb 26, 2008

What steps will reproduce the problem?
1. Start a song
2. Go to lyrics
3. Scroll down

The scrolling should stop when the lyrics end but does not. If you go down
far you have to go all the way up again before you see lyrics.

Comment 1 by dundee.michael, Feb 27, 2008

Took a deeper look at the code and arrived at the conclusion that the bug is an
effect of set_content_size() in scroll_area.py not yet being implemented.

Tags: defect
Joshua Scotton (joshuascotton)
Changed in entertainer:
importance: Undecided → Medium
Revision history for this message
Matt Layman (mblayman) wrote :

I don't agree with the title because I believe it is just a problem of too many newlines being fetched from the lyrics downloader which I've printed directly to the command line. When I printed to the command line, I would often see a finite number of trailing newline characters. However, I do agree that this is a problem and that the final new line characters should be trimmed.

Changed in entertainer:
assignee: nobody → laymansterms
status: New → Confirmed
Revision history for this message
Jamie Bennett (jamiebennett) wrote :

The only problem is where do you draw the line? 2 new lines? 3 new lines? e.t.c. or do you look for text after each new line character and if none is found remove all but the last one?

Revision history for this message
Joshua Scotton (joshuascotton) wrote :

Matt, if it turns out that the bug description is wrong just edit the title by clicking on "edit description/tags" in the action panel

Paul Hummer (rockstar)
Changed in entertainer:
importance: Medium → High
status: Confirmed → Triaged
Paul Hummer (rockstar)
Changed in entertainer:
milestone: none → 0.1-release
Revision history for this message
Charclo (charclo-michael) wrote :

I seem to remember that every lyric had 'lyric from leoslyrics.com'. We could just search for that and cut off the lyric after it.
But for that the lyrics fetching must work first.

Revision history for this message
Jamie Bennett (jamiebennett) wrote :

That would be leoslyrics.com specific. I would like to see a more generic solution. 4 new line characters or more e.t.c?

Revision history for this message
Charclo (charclo-michael) wrote :

I've got lyrics downloading working in my branch and from what I can see it's never endless. I think the height of the lyrics label is just too big most of the time and that's why it seems like endless scrolling. The height of the label should be calculated by the number of lines in the lyrics.

Revision history for this message
Matt Layman (mblayman) wrote :

This is fixed on the branch that I'm pushing up right now.

Changed in entertainer:
status: Triaged → In Progress
Paul Hummer (rockstar)
Changed in entertainer:
status: In Progress → Fix Committed
Revision history for this message
Matt Layman (mblayman) wrote :

Released and available at http://www.entertainer-project.com/download.php

Changed in entertainer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.