Ubuntu
gnome-desktop package

detection of xrandr clone mode is wrong for single screens

Bug #224186 reported by James Westby
6
Affects Status Importance Assigned to Milestone
gnome-desktop (Ubuntu)
Fix Released
Low
Ubuntu Desktop Bugs
Hardy
Fix Released
Low
Ubuntu Desktop Bugs

Bug Description

Hi,

The randr code mistakenly detects all single screen setups as
being in clone mode due to a logic error in the code. The attached
patch inverts the logic so that single screens are never detected
as clone mode.

This exhibits itself as the clone mode checkbox in gnome-display-properties
being set for single screens.

TEST CASE: Install the old version of libgnome-desktop-2 and open
gnome-display-properties with a single screen connected, the clone
checkbox will be on, and the name of your screen will be "Cloned Output".
Install the new version of libgnome-desktop-2 and restart gnome-display-properties.
The checkbox should no longer be active, and the name of your screen
should be related to what it is, and not be "Cloned Output". You should still be
able to attach a second screen and enable or disable cloned output.

Thanks,

James

Revision history for this message
James Westby (james-w) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

I've tested that the change works correctly for me and sponsored the update

Changed in gnome-desktop:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: New → Fix Committed
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into hardy-proposed, please test.

I can test/verify this as well, for the record (both single-screen and dual-screen).

Changed in gnome-desktop:
status: Triaged → Fix Committed
Revision history for this message
Stefano Angeleri (weltall) wrote :

before it detected my dual x screen (no xinerama/no clone) setup as clone. now it doesn't detect the second screen, and the first screen is being identified as "Unknown". The first screen settings can be changed fine.

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 224186] Re: detection of xrandr clone mode is wrong for single screens

On Wed, 2008-04-30 at 15:45 +0000, weltall wrote:
> before it detected my dual x screen (no xinerama/no clone) setup as
> clone. now it doesn't detect the second screen, and the first screen is
> being identified as "Unknown". The first screen settings can be changed
> fine.
>

Hi,

Thanks for testing.

When you say "before" and "now", are you referring to before and after
installing the update from the -proposed repository on to Hardy?

When you say that the second screen isn't detected you mean that there
is no second rectangle shown at all for that screen, or something else?

It being "Unknown" rather than clone now is just a side effect of the
bug fix I think.

Thanks,

James

Revision history for this message
Stefano Angeleri (weltall) wrote :

yes i'm referring for before as official release package status and now as after installing the package listed in proposed repository.
Exactly there is no second rectangle listed. The setup is done trough the xorg.conf configuration in order to have two separate xscreens.
After some additional tests i noticed that if i launch gnome-display-properties on the second monitor it can manage the second monitor but not the first one... maybe it's just a side effect of my setup?
anyway the status before was worse (as detecting two screens as clone when one is right of the other is plainly wrong) so it's an improvement anyway...

Revision history for this message
James Westby (james-w) wrote :

On Thu, 2008-05-01 at 06:36 +0000, weltall wrote:
> yes i'm referring for before as official release package status and now as after installing the package listed in proposed repository.
> Exactly there is no second rectangle listed. The setup is done trough the xorg.conf configuration in order to have two separate xscreens.
> After some additional tests i noticed that if i launch gnome-display-properties on the second monitor it can manage the second monitor but not the first one... maybe it's just a side effect of my setup?
> anyway the status before was worse (as detecting two screens as clone when one is right of the other is plainly wrong) so it's an improvement anyway...
>

Hi,

Thanks for clarifying what you are seeing.

I don't see how the changes in this package could affect the number of
screens that are found.

By any chance are your two monitors the same size? Have you tried
dragging the monitor rectangle around to see if the other is underneath?

Thanks,

James

Revision history for this message
Martin Pitt (pitti) wrote :

I tested the upgrade on my desktop and laptop, the latter with just the internal VGA and with attaching an external TFT. It worked correctly for me, verified for my side. Waiting for another successful tester.

Revision history for this message
Sebastien Bacher (seb128) wrote :

the upgrade works correctly for me too, I tried using a laptop and a tft external monitor too

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in gnome-desktop:
status: Fix Committed → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

copied to intrepid

Changed in gnome-desktop:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.