Backport bugfixes from Transmission 1.1x for Hardy

Looks good, lots of bug fixes, and "dozens of usability, Gnome HIG, and i18n improvements".

I'm neutral on this because 1.10 is great but 1.06 is a known quantity.

Here's a list of the tickets handled in 1.10:

http://trac.transmissionbt.com/query?group=component&milestone=1.10

For this to happen, you'll need to provide all the information listed at https://wiki.ubuntu.com/FreezeExceptionProcess#head-30ede7e753a6b6f62916161755507d4cc5d99e20 and subscribe ubuntu-main-sponsors.

My initial gut feeling is negative on this. While there are a lot of bugfixes, it seems like the amount of code changes and feature additions is also quite significant, and it would not be wise to make such a major change this late in the development cycle to our *default torrent client* that is installed to every Ubuntu machine!

Rather, if Charles or anyone else is knowledgeable about the most commonly experienced or most serious bugs in 1.06 fixed by some svn changeset between then and 1.10, I'd rather do isolated patch backports.

Attached is a patch against 1.06 that backports some of 1.10's changes. I chose fixes whose diffs were limited in scope and unlikely to cause any ripples, so there aren't any of 1.10's sexy new features. :) I'll run this patched version for the next few days and am uploading the patch now in case anyone else wants to kick it around too.

http://trac.transmissionbt.com/ticket/698
`have' gets too far ahead of `verified'

http://trac.transmissionbt.com/ticket/727
setting download speed to 0 kills upload speed

http://trac.transmissionbt.com/ticket/739
documentation inconsistency for transmission-remote (-s and -S)

http://trac.transmissionbt.com/ticket/742
gtk dialogs should support `alternative button order'

http://trac.transmissionbt.com/ticket/771
segfault in strlcpy when trying to open a torrent

http://trac.transmissionbt.com/ticket/781
some data is being misreported as corrupt

http://trac.transmissionbt.com/ticket/798
1.06's handling of http redirects can strain hotspots

Other patches that IMO should be considered for Heron:

https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/207844
transmissioncli: manpage still mentions -o

https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/192945
missing icon on window border and window list

I think it would be good to have a full version of 1.10 in Hardy, it's an LTS.. an there are a lot of nice features, that are missed for long time...

Please make it for hardy, we still have time for testing it and fix future problems.

I really like 1.10 too, but I feel like we should err on the side of caution.

Other patches for consideration in Heron:

https://bugs.launchpad.net/transmission/+bug/209719
XML entity references are displayed instead of some characters

I agree that it could be a bad idea to change a default application this late in the development cycle, however I think it is worse to have all the bugs that is in 1.06 in a default application in Hardy Heron.

Another bugfix release, version 1.11, has been released, fixing in the GTK version a couple of minor display issues.

Sorry for the bug spam, momentary lack of judgement.

Everyone: Note the updated description of the task. Since ClamAV needs a similarly intrusive update, the Backports team has decided to open up Hardy Backports earlier this release cycle, so we will handle the new 1.1x branch in Backports on a timely manner.

At the same time, we will go forward with applying Charles's patches to the Hardy 1.06 package.

For this to continue, Charles, can you separate out your patches into one change per patchfile? We will add a patch system into the Transmission package if necessary. This will facilitate reviewing and maintaining the package for Hardy. Thanks!

I added a patch system while we await the splitting out of patches.

John, attached is the patch you requested. Note that I didn't
include #192945's "missing icon on window border" patch
because I can't test that.

Tickets covered by this patch:

* http://trac.transmissionbt.com/ticket/771
  segfault in strlcpy when trying to open a torrent

* http://trac.transmissionbt.com/ticket/698
  `have' gets too far ahead of `verified'

* http://trac.transmissionbt.com/ticket/781
  some data is being misreported as corrupt

* http://trac.transmissionbt.com/ticket/727
  setting download speed to 0 kills upload speed

* http://trac.transmissionbt.com/ticket/798
  1.06's handling of http redirects can strain hotspots

* https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/215681
  http://trac.transmissionbt.com/ticket/862
  gtk client's "--minimized" command-line argument doesn't work

* https://bugs.launchpad.net/transmission/+bug/209719
  XML entity references are displayed instead of some characters

* http://trac.transmissionbt.com/ticket/742
  gtk dialogs should support `alternative button order'

* http://trac.transmissionbt.com/ticket/850
  download individual file's checkbox so far away from its title

* http://trac.transmissionbt.com/ticket/739
  transmission-remote manpage (-s and -S)

* https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/207844
  http://trac.transmissionbt.com/ticket/825
  transmissioncli: manpage still mentions -o

Could you please also backport the fix for this one:

* https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/191607
   Transmisson crashes X

I didn't include that patch because I didn't feel as comfortable with the backport -- it's diffs are larger than the other tickets backported.

If the Hardy team wants me to, though, I will.

Well, as it stands now Hardy ships with an application that is installed by default and crashes X completely for some people.

I think the priorities should be clear here.

I'd like someone on the Hardy team to weigh in on it.

I'm reasonably sure that the patch attached above doesn't have any side-effects and would be an improvement over the current package.

Hi Charles, regarding the patch for the missing icon (bug #192945), you can see a few people have tested and commented on it, including myself. Worked great for me. I would love to see this in Hardy because as I mentioned in the other bug, applications without icons are hard to manage when using an icon-based task list, like a dock (in my case AWN), instead of a text-based task list.

Mike, sounds good to me. However someone on the Hardy release team will need to give approval, not me.

What about backporting 1.22 from Intrepid into Hardy?

Brett Alton, see this:
https://bugs.launchpad.net/hardy-backports/+bug/213682

Have to agree with Tim Fuchs' comment, at the very least, backporting https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/191607 would be a good idea for hardy-updates too, did an install on a brand new laptop tonight and Transmission died using the exact procedure listed at http://trac.transmissionbt.com/ticket/770.

Users get scared at the word 'Unsupported', especially when their first experience with a non-Windows platform is Ubuntu and among the reason they tried to install it was the words 'Long Term Support' in the title (something neither Win98 or Win2000 -- the operating environments said user comes from -- get much of, these days).

Test packages for hardy-backports can be found for now in my ppa:

https://launchpad.net/~kitterman/+archive

I have just tested Scott's package from his ppa and it works without problems until now, i also haven't had problems upgrading from the version i have installed from the ubuntu archives.

Source backport uploaded. Waiting for archive-admins to accept now.

1.06 has had some patches added. So this is as fixed as it's going to get. Other issues should be pursued as a separate bug. Backport of 1.22 is pending.

Manual upload accepted, thanks Scott!