Prism

Window icon shoud be site favicon

Bug #205782 reported by KillerKiwi
2
Affects Status Importance Assigned to Milestone
Prism
Fix Released
Wishlist
prism (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

All prism windows have the same icon in the window list or awn.

This makes it hard to identify apps at a glance

instead the icon should be the site favicon

See original description

Related branches

lp:prism
lp:ubuntu/karmic/prism
Revision history for this message
In , Mark-finkle (mark-finkle) wrote :

*** Bug 407157 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 294074
WIP, full patch of all my changes so far including preliminary favicon support

This patch includes the code for bugs 400179 and 408362. I haven't posted the latter yet since I want to test on Windows first. Currently includes support for Windows and Mac, tested only on Mac.

Currently I download the favicon to the profile directory, which is kind of a hack, and then check whether it is there when the user clicks OK to create the app/shortcut. So if they click before the icon is downloaded they will get the default app icon. I'll figure out a way to hold the icon in memory so it doesn't have to be written to disk. The UI should take care of showing the user that the icon is loading and displaying it once it is loaded so they can decide if they want it or some other icon.

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 294075
Icon for use with attachment 294074

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 294251
Latest WIP

This is tested and works on Mac and Windows. It's ready for review. Unfortunately it's beyond my abilities to make a proper patch until bug 408362 is committed. In the meantime, here's the latest WIP. As soon as we get consensus on 408362 and get it checked in I'll make a proper patch.

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 295772
Consolidate patch to use platform-independent icons and generate from favicon if not available

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 295777
New patch, same as the old patch (but without the extraneous files)

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 295789
Fixes build issues on win32,, add supports for 256x256 and 512x512 icons

I haven't tested the 512x512 and 256x256 icon support since this is only for Leopard and I have Tiger.

Revision history for this message
In , Mark-finkle (mark-finkle) wrote :

Comment on attachment 295789
Fixes build issues on win32,, add supports for 256x256 and 512x512 icons

tweaked common/components/src/windows/Makefile.in to use static CRT and add a manifest

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 296114
Get rid of the temporary file when generating from favicon

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

*** Bug 400179 has been marked as a duplicate of this bug. ***

Revision history for this message
KillerKiwi (killerkiwi2005) wrote :

All prism windows have the same icon in the window list or awn.

This makes it hard to identify apps at a glance

instead the icon should be the site favicon

Revision history for this message
Fabien Tassin (fta) wrote :

This is a known long standing bug caused by xulrunner-1.9 no longer supporting XPM. Those files should be converted to PNG instead.
Assigning to me.

Changed in prism:
assignee: nobody → fta
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Fabien Tassin (fta) wrote :

I've fixed the regression with desktop icons introduced since xulrunner 1.9b3 by https://bugzilla.mozilla.org/show_bug.cgi?id=410215

As for favicon, it's supported in Prism 0.9, not packaged at this point (license issue with webapps to solve first).

Changed in prism:
assignee: fta → nobody
Revision history for this message
Fabien Tassin (fta) wrote :

er.. s/desktop icons/windows icons/

Revision history for this message
Fabien Tassin (fta) wrote :

I'm tagging this as fix comitted as the webapps shipped in hardy have their window's icon back.
Yet, it's not favicon so it won't work for alien/custom webapps which still need to ship their PNG icon inside the bundle.

Changed in prism:
status: In Progress → Fix Committed
Revision history for this message
KillerKiwi (killerkiwi2005) wrote :

Thanks Fabien.. cant complain with that turnaround

Fabien Tassin (fta)
Changed in prism:
importance: Undecided → Medium
status: New → Fix Committed
Fabien Tassin (fta)
Changed in prism:
importance: Medium → Unknown
status: Fix Committed → Unknown
Bug Watch Updater (bug-watch-updater)
Changed in prism:
status: Unknown → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package prism - 0.8+svn20071115r8030-0ubuntu3

---------------
prism (0.8+svn20071115r8030-0ubuntu3) hardy; urgency=low

  * Use PNG instead of deprecated XPM for windows icons (LP: #205782, #206180)
    Build-depends on zip, imagemagic (convert) and shareutils (uudecode)
    - add debian/patches/use_png_for_windows_icons_on_linux.patch
    - update debian/patches/series
    - add debian/prism.png.uu
    - update debian/control
    - update debian/rules
    - update debian/prism-*.install
    - update debian/update-apps.sh

 -- Fabien Tassin <email address hidden> Mon, 24 Mar 2008 16:39:37 +0100

Changed in prism:
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in prism:
importance: Unknown → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.