ValueError on +language-packs
Bug #196679 reported by
Diogo Matsubara
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Henning Eggers |
Bug Description
As seen in OOPS-788EB21 a ValueError was raised and the exception value is list.remove(x): x not in list
Carlos has a hypothesis for this bug:
<carlos> the problem is having a base language pack set for a distro series
<carlos> and also an update package
<carlos> and change the base package to a newer one (using an old one should have the same effect)
<carlos> the update one is not valid anymore, but seems like we are not unsetting it
<carlos> and thus, our code breaks
It needs further investigation to confirm if this is the real cause.
Related branches
lp:~henninge/launchpad/bug-196670-move-language-pack-type
- Henning Eggers (community): Approve (code)
-
Diff: 167 lines (+26/-30)7 files modifiedlib/canonical/launchpad/vocabularies/dbobjects.py (+1/-1)
lib/lp/registry/model/distroseries.py (+2/-1)
lib/lp/translations/doc/language-pack.txt (+2/-2)
lib/lp/translations/enums.py (+15/-0)
lib/lp/translations/interfaces/languagepack.py (+3/-21)
lib/lp/translations/model/languagepack.py (+1/-1)
lib/lp/translations/scripts/language_pack.py (+2/-4)
lp:~henninge/launchpad/bug-196679-language-packs-value-error
- Graham Binns (community): Approve (code)
-
Diff: 136 lines (+78/-7)3 files modifiedlib/lp/testing/factory.py (+15/-2)
lib/lp/translations/browser/distroseries.py (+4/-5)
lib/lp/translations/browser/tests/test_distroseries_views.py (+59/-0)
Changed in rosetta: | |
assignee: | nobody → carlos |
Changed in rosetta: | |
assignee: | carlos → nobody |
Changed in rosetta: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in launchpad: | |
importance: | Medium → Critical |
Changed in launchpad: | |
assignee: | nobody → Henning Eggers (henninge) |
status: | Triaged → In Progress |
Changed in launchpad: | |
milestone: | 11.05 → 11.06 |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: | removed: qa-untestable |
tags: | added: qa-untestable |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12986 (http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12986) by a commit, but not testable.