Launchpad itself

private snap recipes do not trigger on branch update

Bug #1927950 reported by Andy Whitcroft
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tom Wardill

Bug Description

For a private snap recipe branch updates are not detected, and no builds are scheduled.

"The request-builds side of things is fine, but the mark-snaps-stale side of things incorrectly only considers public snaps."

Related branches

~twom/launchpad:snap-privacy-is-never-stale
Colin Watson (community): Approve
Diff: 143 lines (+43/-9)
6 files modified
lib/lp/code/model/branch.py (+4/-1)
lib/lp/code/model/gitrepository.py (+5/-1)
lib/lp/code/model/tests/test_gitrepository.py (+11/-0)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+12/-0)
lib/lp/snappy/interfaces/snap.py (+2/-2)
lib/lp/snappy/model/snap.py (+9/-5)
Revision history for this message
Colin Watson (cjwatson) wrote :

`Branch.markSnapsStale` and `GitRepository.markSnapsStale` call `SnapSet.findByBranch` and `SnapSet.findByGitRepository` respectively. They don't pass `visible_by_user`, which the find methods interpret as meaning that they're looking up snaps visible to an anonymous user in the web UI, i.e. only public snaps.

The usual approach is to have a `check_permissions=True` keyword argument, and to skip the privacy filter when `check_permissions=False` is passed.

tags: added: lp-snappy privacy
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Colin Watson (cjwatson)
summary: - private snap recipies do not trigger on branch update
+ private snap recipes do not trigger on branch update
Tom Wardill (twom)
Changed in launchpad:
status: Triaged → Fix Committed
assignee: nobody → Tom Wardill (twom)
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.