netplan ovs's key deletion is fubared

Bug #1913906 reported by deadalnix
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Netplan
Fix Released
Undecided
Unassigned

Bug Description

See the code at:

https://github.com/CanonicalLtd/netplan/blob/fad12c1/netplan/cli/ovs.py#L52

The value is passed down to ovs-vsctl. In the best case, it does nothing. In the worse case, the value is not a valid key and you get an error (for instance, if the value contains a `:`). In the worst case the value is another key in the table and we delete an entry for no good reason.

Revision history for this message
Dave Heinz (disirk74) wrote :

I am having the issue with the `:` as detailed in https://bugs.launchpad.net/netplan/+bug/1918197

Revision history for this message
Dave Heinz (disirk74) wrote :

For my use case, I changed Line 52 mentioned in your description to the following:

subprocess.check_call([OPENVSWITCH_OVS_VSCTL, 'remove', type, iface, column, key])

It now works for MY scenario, but not sure it would work for all.

Revision history for this message
Lukas Märdian (slyon) wrote :

This is being worked on here: https://github.com/canonical/netplan/pull/203

Changed in netplan:
status: New → In Progress
Lukas Märdian (slyon)
Changed in netplan:
status: In Progress → Fix Committed
Revision history for this message
deadalnix (deadalnix) wrote :

Thanks!

Lukas Märdian (slyon)
Changed in netplan:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.