ESP should be fscked

Bug #1912835 reported by Dimitri John Ledkov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Groovy
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

 * ESP can be not clean, thus failing to mount on boot.

 * fsck should be enabled for ESP partition.

[Test Case]

 * $ systemctl status systemd-fsck*.service

  On boot, that should produce status for two drives, the one with short uuid should be the one mounted as /ESP

[Where problems could occur]

 * The change will affect only newly deployed instances. Old instances will have to correct this in fstab themselves.

Related branches

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.710

---------------
livecd-rootfs (2.710) hirsute; urgency=medium

  * esp: install grub in ubuntu bootloader id path, instead of removable.
    (LP: #1912830)
  * esp: perform fsck. (LP: #1912835)

 -- Dimitri John Ledkov <email address hidden> Thu, 28 Jan 2021 10:43:20 +0000

Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

however ESP fsck is missing in the bootable buildd images.

and rootfs fsck is missing in all other fstabs.

Fixing that too, under this same bug number.

Changed in livecd-rootfs (Ubuntu):
status: Fix Released → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.711

---------------
livecd-rootfs (2.711) hirsute; urgency=medium

  * Perform fsck on all rootfs. (LP: #1912835)
  * functions: stop removing systemd-detect-virt unconditionally in undivert_grub
    (LP: #1902260)

 -- Dimitri John Ledkov <email address hidden> Fri, 05 Feb 2021 12:48:44 +0000

Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted livecd-rootfs into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.694.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Groovy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-groovy
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Dimitri, or anyone else affected,

Accepted livecd-rootfs into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.664.17 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed-focal
Changed in livecd-rootfs (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Dimitri, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.51 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Dimitri, or anyone else affected,

Accepted livecd-rootfs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.408.66 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed-xenial
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (livecd-rootfs/2.408.66)

All autopkgtests for the newly accepted livecd-rootfs (2.408.66) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-image/1.10+16.04ubuntu1 (arm64, i386, s390x, amd64, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#livecd-rootfs

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

From https://launchpad.net/~xnox/+livefs/ubuntu/groovy/any/+build/259784

downloading the vmdk image

mounting p15 i can see that /ubuntu/ paths now exist, and will be used for booting via BOOTX64.CSV

 tree /mnt/
/mnt/
└── EFI
    ├── BOOT
    │   ├── BOOTX64.EFI
    │   ├── fbx64.efi
    │   └── mmx64.efi
    └── ubuntu
        ├── BOOTX64.CSV
        ├── grub.cfg
        ├── grubx64.efi
        ├── mmx64.efi
        └── shimx64.efi

3 directories, 8 files

Mounting the p1 partition I can see that fsck will be performed on both partitions

$ cat /mnt/etc/fstab
LABEL=cloudimg-rootfs / ext4 defaults 0 1
LABEL=UEFI /boot/efi vfat defaults 0 1

$ /mnt/usr/bin/systemd-detect-virt
none

can be executed and is present (although this image would not have triggered the bug of missing systemd-detect-virt, this bug would need to be verified elsewhere)

tags: added: verification-done-groovy
removed: verification-needed-groovy
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

From https://launchpad.net/~xnox/+livefs/ubuntu/focal/any/+build/259783

downloading the .img (qcow) image

mounting p15 i can see that /ubuntu/ paths now exist, and will be used for booting via BOOTX64.CSV

 tree /mnt/
/mnt/
└── EFI
    ├── BOOT
    │ ├── BOOTX64.EFI
    │ ├── fbx64.efi
    │ └── mmx64.efi
    └── ubuntu
        ├── BOOTX64.CSV
        ├── grub.cfg
        ├── grubx64.efi
        ├── mmx64.efi
        └── shimx64.efi

3 directories, 8 files

Mounting the p1 partition I can see that fsck will be performed on both partitions

$ cat /mnt/etc/fstab
LABEL=cloudimg-rootfs / ext4 defaults 0 1
LABEL=UEFI /boot/efi vfat defaults 0 1

$ LD_PRELOAD=/mnt/usr/lib/systemd/libsystemd-shared-245.so /mnt/usr/bin/systemd-detect-virt
none

can be executed and is present (although this image would not have triggered the bug of missing systemd-detect-virt, this bug would need to be verified elsewhere)

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

From https://launchpad.net/~xnox/+livefs/ubuntu/bionic/any/+build/259782

downloading the .img (qcow) image

mounting p15 i can see that /ubuntu/ paths now exist, and will be used for booting via BOOTX64.CSV

$ tree /mnt/
/mnt/
└── EFI
    ├── BOOT
    │   ├── BOOTX64.EFI
    │   └── fbx64.efi
    └── ubuntu
        ├── BOOTX64.CSV
        ├── grub.cfg
        ├── grubx64.efi
        ├── mmx64.efi
        └── shimx64.efi

3 directories, 7 files

Mounting the p1 partition I can see that fsck will be performed on both partitions

$ cat /mnt/etc/fstab
LABEL=cloudimg-rootfs / ext4 defaults 0 1
LABEL=UEFI /boot/efi vfat defaults 0 1

$ sudo chroot /mnt/ /usr/bin/systemd-detect-virt
Failed to check for virtualization: No such file or directory

can be executed and is present (although this image would not have triggered the bug of missing systemd-detect-virt, this bug would need to be verified elsewhere)

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

From https://launchpad.net/~xnox/+livefs/ubuntu/xenial/any/+build/259781

downloading the livecd.ubuntu-cpc.uefi1.img image.

mounting p1 i can see that:

$ cat /mnt/etc/fstab
LABEL=cloudimg-rootfs / ext4 defaults 0 1
LABEL=UEFI /boot/efi vfat defaults 0 1

fsck will be performed

$ file /mnt/usr/bin/systemd-detect-virt
/mnt/usr/bin/systemd-detect-virt: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=48194abca8f0a3e7b9e698e2dcf114e787057a00, stripped

systemd-detect-virt exists. Although the bug in question would not be triggered on any xenial images.

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted livecd-rootfs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.408.67 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-xenial
removed: verification-done verification-done-xenial
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (livecd-rootfs/2.408.67)

All autopkgtests for the newly accepted livecd-rootfs (2.408.67) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-image/1.10+16.04ubuntu1 (s390x, ppc64el, amd64, arm64, i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#livecd-rootfs

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

https://launchpad.net/~xnox/+livefs/ubuntu/xenial/any/+build/259925

Get:89 http://ftpmaster.internal/ubuntu xenial-proposed/main amd64 livecd-rootfs amd64 2.408.67 [73.6 kB]

downloading uefi image

p15 is bootable

$ tree /mnt/
/mnt/
├── boot
│   └── grub
│   └── grub.cfg
└── EFI
    └── BOOT
        ├── BOOTX64.EFI
        ├── grub.cfg
        ├── grubx64.efi
        └── mmx64.efi

with removable paths only.

p1 has fsck and systemd-detect-virt is real:

$ cat /mnt/etc/fstab
LABEL=cloudimg-rootfs / ext4 defaults 0 1
LABEL=UEFI /boot/efi vfat defaults 0 1

$ file /mnt/usr/bin/systemd-detect-virt
/mnt/usr/bin/systemd-detect-virt: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=48194abca8f0a3e7b9e698e2dcf114e787057a00, stripped

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.694.3

---------------
livecd-rootfs (2.694.3) groovy; urgency=medium

  [ David Krauser ]
  * buildd: produce kernel and initrd as separate artifacts LP: #1910557
  * buildd: call update-initramfs for all installed kernels
    We only have one kernel installed, so we don't need to
    specify an explicit version. LP: #1910557

  [ Dimitri John Ledkov ]
  * esp: install grub in ubuntu bootloader id path, instead of removable.
    (LP: #1912830)
  * esp: perform fsck. (LP: #1912835)
  * Perform fsck on all rootfs. (LP: #1912835)
  * functions: stop removing systemd-detect-virt unconditionally in undivert_grub
    (LP: #1902260)

livecd-rootfs (2.694.2) groovy; urgency=medium

  [ Cody Shepherd ]
  * Create manifests for buildd tarball images (LP: #1914445)

 -- Dimitri John Ledkov <email address hidden> Tue, 09 Feb 2021 00:40:38 +0000

Changed in livecd-rootfs (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.664.17

---------------
livecd-rootfs (2.664.17) focal; urgency=medium

  [ David Krauser ]
  * buildd: produce kernel and initrd as separate artifacts LP: #1910557
  * buildd: call update-initramfs for all installed kernels
    We only have one kernel installed, so we don't need to
    specify an explicit version. LP: #1910557

  [ Dimitri John Ledkov ]
  * esp: install grub in ubuntu bootloader id path, instead of removable.
    (LP: #1912830)
  * esp: perform fsck. (LP: #1912835)
  * Perform fsck on all rootfs. (LP: #1912835)
  * functions: stop removing systemd-detect-virt unconditionally in undivert_grub
    (LP: #1902260)

livecd-rootfs (2.664.16) focal; urgency=medium

  [ Cody Shepherd ]
  * Produce manifests for buildd tarball images (LP: #1914445)

 -- Dimitri John Ledkov <email address hidden> Tue, 09 Feb 2021 00:52:00 +0000

Changed in livecd-rootfs (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.525.51

---------------
livecd-rootfs (2.525.51) bionic; urgency=medium

  [ David Krauser ]
  * buildd: produce kernel and initrd as separate artifacts LP: #1910557
  * buildd: call update-initramfs for all installed kernels
    We only have one kernel installed, so we don't need to
    specify an explicit version. LP: #1910557

  [ Dimitri John Ledkov ]
  * esp: install grub in ubuntu bootloader id path, instead of removable.
    (LP: #1912830)
  * esp: perform fsck. (LP: #1912835)
  * Perform fsck on all rootfs. (LP: #1912835)
  * functions: stop removing systemd-detect-virt unconditionally in undivert_grub
    (LP: #1902260)

livecd-rootfs (2.525.50) bionic; urgency=medium

  [ Cody Shepherd ]
  * Create manifests for buildd tarball images (LP: #1914445)

 -- Dimitri John Ledkov <email address hidden> Tue, 09 Feb 2021 00:59:37 +0000

Changed in livecd-rootfs (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.408.67

---------------
livecd-rootfs (2.408.67) xenial; urgency=medium

  * Revert "esp: install grub in ubuntu bootloader id path, instead of
    removable." as xenial's grub doesn't support shim fallback mode.

livecd-rootfs (2.408.66) xenial; urgency=medium

  [ David Krauser ]
  * buildd: produce kernel and initrd as separate artifacts LP: #1910557
  * buildd: call update-initramfs for all installed kernels
    We only have one kernel installed, so we don't need to
    specify an explicit version. LP: #1910557

  [ Dimitri John Ledkov ]
  * esp: install grub in ubuntu bootloader id path, instead of removable.
  * esp: perform fsck. (LP: #1912835)
  * Perform fsck on all rootfs. (LP: #1912835)
  * functions: stop removing systemd-detect-virt unconditionally in undivert_grub
    (LP: #1902260)

 -- Dimitri John Ledkov <email address hidden> Wed, 10 Feb 2021 13:00:48 +0000

Changed in livecd-rootfs (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.