Allow for disabling built-in rate limiting
Bug #1910977 reported by
Tom Haddon
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| charm-k8s-discourse |
Fix Released
|
High
|
Unassigned | ||
Bug Description
As of Discourse 2.6.0 anonymous rate limiting was made much more aggressive than previously.
We need a way to be able to disable that rate limiting in the charm.
Related branches
~jk0ne/charm-k8s-discourse/+git/charm-k8s-discourse:master
- Tom Haddon: Approve
- Jay Kuri (community): Needs Resubmitting
-
Diff: 438 lines (+166/-52)13 files modifiedMakefile (+1/-1)
config.yaml (+13/-1)
dev/null (+0/-22)
image/Dockerfile (+2/-6)
image/scripts/pod_setup (+0/-6)
src/charm.py (+62/-4)
tests/unit/fixtures/config_invalid_bad_throttle_mode.yaml (+25/-0)
tests/unit/fixtures/config_invalid_missing_cors.yaml (+4/-0)
tests/unit/fixtures/config_invalid_missing_db_name.yaml (+4/-0)
tests/unit/fixtures/config_valid_complete.yaml (+15/-4)
tests/unit/fixtures/config_valid_with_tls.yaml (+19/-4)
tests/unit/fixtures/config_valid_without_tls.yaml (+20/-4)
tests/unit/test_charm.py (+1/-0)
Revision history for this message
| Jay Kuri (jk0ne) wrote | #1 |
| Changed in charm-k8s-discourse: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
Revision history for this message
| Jay Kuri (jk0ne) wrote | #2 |
| Changed in charm-k8s-discourse: | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
I believe the best solution here is to change how Discourse is obtaining its GlobalSettings to work from the environment. This is how the official Discourse docker image handles configuration and would allow the k8s charm to more closely follow the upstream configuration documentation.
We will need to investigate how they accomplish this in the official image.