Ubuntu
firefox package

Flash plugin symbol lookup error with firefox 80.0+build2 on xenial (gtk_window_set_titlebar)

Bug #1893021 reported by Olivier Tilloy
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mozilla Firefox
Fix Released
Unknown
firefox (Ubuntu)
Fix Released
High
Olivier Tilloy

Bug Description

When testing firefox 80.0+build2 on xenial (from https://launchpad.net/~ubuntu-mozilla-security/+archive/ubuntu/ppa/+packages), I'm observing that the flash plugin (installed by flashplugin-installer) doesn't work. This appears to affect only xenial, flash is working in the bionic and focal builds.

This is what I'm seeing when launching firefox from a terminal:

  /usr/lib/firefox/plugin-container: symbol lookup error: /usr/lib/firefox/libxul.so: undefined symbol: gtk_window_set_titlebar

This is most likely caused by this recent upstream change: https://phabricator.services.mozilla.com/D84623

Revision history for this message
Olivier Tilloy (osomon) wrote :

The problem is with GTK function stubs being declared in the wrong sections in widget/gtk/mozgtk/mozgtk.c. Another recent upstream change did that too: https://phabricator.services.mozilla.com/D82804.

And this patch fixes it: https://bazaar.launchpad.net/~mozillateam/firefox/firefox.xenial/revision/1450

Changed in firefox (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
treloar (treloar) wrote :

How does one apply patch?

Revision history for this message
In , Olivier Tilloy (osomon) wrote :

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.83 Safari/537.36

Steps to reproduce:

Downstream (Ubuntu) bug report: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1893021

With the release of firefox 80.0, loading the flash plugin on Ubuntu 16.04 was failing with the following error:

    /usr/lib/firefox/plugin-container: symbol lookup error: /usr/lib/firefox/libxul.so: undefined symbol: gtk_window_set_titlebar

Actual results:

In previous releases, loading the flash plugin worked fine.

Expected results:

This regression was caused by two recent revisions: https://phabricator.services.mozilla.com/D84623 and https://phabricator.services.mozilla.com/D82804, which added GTK function stubs (in widget/gtk/mozgtk/mozgtk.c in the wrong section (they were added to the COMMON_SYMBOLS section but they should be in the GTK3_SYMBOLS because they are GTK3 only).

Revision history for this message
Olivier Tilloy (osomon) wrote :

Upstream bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1661715

Revision history for this message
In , Olivier Tilloy (osomon) wrote :

Created attachment 9172666
Bug 1661715 - Move GTK function stubs to the correct section.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Patch submitted upstream: https://phabricator.services.mozilla.com/D88588

Revision history for this message
Olivier Tilloy (osomon) wrote :

> How does one apply patch?

Just wait for the update to be available in xenial-security, which should happen later today.

Revision history for this message
In , Release-mgmt-account-bot (release-mgmt-account-bot) wrote :

[Bugbug](https://github.com/mozilla/bugbug/) thinks this bug should belong to this component, but please revert this change in case of error.

Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Unknown → New
Revision history for this message
treloar (treloar) wrote :

I've received no update thus far, so I tried a re-install and still have no flash in firefox.

I am on Ubuntu 16.04.7 LTS Xenial x86_64

Revision history for this message
In , Pulsebot (pulsebot) wrote :

Pushed by <email address hidden>:
https://hg.mozilla.org/integration/autoland/rev/5d87a8dae5fe
Move GTK function stubs to the correct section. r=karlt

Revision history for this message
In , Apavel-2 (apavel-2) wrote :

https://hg.mozilla.org/mozilla-central/rev/5d87a8dae5fe

Revision history for this message
Olivier Tilloy (osomon) wrote :

The patch was accepted upstream: https://hg.mozilla.org/mozilla-central/rev/5d87a8dae5fe55360890e4ea4ed12135a8e909ed

Revision history for this message
Olivier Tilloy (osomon) wrote :

treloar: the update is pending publication by the security team, thanks for your patience.

Revision history for this message
In , Robert Mader (robert.posteo) wrote :

Ouch, sorry and thanks for that!

Revision history for this message
In , Ryanvm (ryanvm) wrote :

Please nominate this for Beta approval when you get a chance.

Revision history for this message
In , Olivier Tilloy (osomon) wrote :

Sure. I'm not sure how to nominate a bug/revision for beta approval, though?

Revision history for this message
In , Karlt (karlt) wrote :

https://hg.mozilla.org/mozilla-central/rev/45e8dd195f71 actually landed in 80.

Revision history for this message
In , Karlt (karlt) wrote :

Comment on attachment 9172666
Bug 1661715 - Move GTK function stubs to the correct section.

### Beta/Release Uplift Approval Request
* **User impact if declined**: Flash plugin fails to load.
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**:
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The change affects only plugins.
* **String changes made/needed**: None.

Revision history for this message
In , Ryanvm (ryanvm) wrote :

Comment on attachment 9172666
Bug 1661715 - Move GTK function stubs to the correct section.

Approved for 81.0b5.

Revision history for this message
In , Ryanvm (ryanvm) wrote :

https://hg.mozilla.org/releases/mozilla-beta/rev/02a9269355fc

Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 80.0.1+build1-0ubuntu0.16.04.1

---------------
firefox (80.0.1+build1-0ubuntu0.16.04.1) xenial; urgency=medium

  * New upstream stable release (80.0.1+build1)

 -- Olivier Tilloy <email address hidden> Tue, 01 Sep 2020 11:25:05 +0200

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
treloar (treloar) wrote :

Awesome the bug patch just came through for me and now flash in Firefox 80.0.1 is working, thank-you very much Olivier Tilloy

Revision history for this message
In , Fdiciocco (fdiciocco) wrote :

Created attachment 9174007
'GTK_IS_STYLE_CONTEXT (context)' failed

Hi,

On Ubuntu 16.04 LTS I downloaded FF Nightly 82.0a1 (2020-08-28) (64-bit), opened it from a terminal with the command ./firefox -p and I did not see the error message. But when I closed the browser and ran the same command again, hence restarting and updating nightly to 82.0a1 (2020-09-04) (64-bit), I saw the attached error messages.
How should we proceed?

Revision history for this message
In , Fdiciocco (fdiciocco) wrote :

Repeated comment, please ignore it

Revision history for this message
In , Stransky (stransky) wrote :

I think you can safely ignore that, that comes from Gtk3 library which complains about error in actual Gtk theme. Eventually you can change your Gtk theme in gnome-tweaks application.

Revision history for this message
In , Fdiciocco (fdiciocco) wrote :

Ok, thanks for the answer. So I proceed to change the bug from resolved to verify.

Regards, Flor.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.