If import is called with all_stores_must_succeed=True and a store fails during set_image_data(), the store will remain in os_glance_importing_stores forever, never going into the os_glance_failed_import list. This means a polling client will never notice that the import failed. Further, if multiple stores are included in the import, and the failure happens in the later stores, the revert process will remove the earlier stores (after they had already been reported as available in stores). This means a polling client doing an import on an image already in store1 to store2,store3,store4 will see the following progression:
stores=store1;os_glance_importing_to_stores=store2,store3,store4
stores=store1,store2;os_glance_importing_to_stores=store3,store4
stores=store1,store2,store3;os_glance_importing_to_stores=store4
stores=store1,store2;os_glance_importing_to_stores=store4
stores=store1;os_glance_importing_to_stores=store4
The last line, forever, and never see anything in os_glance_failed_import
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit ec372377b1e69eb
Author: Dan Smith <email address hidden>
Date: Wed Aug 12 09:28:46 2020 -0700
Functional reproducer for bug 1891352
This reproduces the behavior described in the referenced bug, showing
the behavior before the fix. This asserts the *broken* behavior and leaves
examples of what the asserts should be for the fix patch.
Partial-Bug: #1891352
Change-Id: I992a14abb7cb41