optimize check_flashcopy_rate to avoid redundant lssystem calls

Bug #1890586 reported by Chhavi Agarwal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
katari manoj kumar

Bug Description

check_flashcopy_rate makes lsssystem calls each time to fetch the code_level.
this can be optimized to store the code_level and do comparison.

Changed in cinder:
assignee: nobody → katari manoj kumar (katarimanojkumar)
Eric Harney (eharney)
tags: added: drivers storwize
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/745470

Changed in cinder:
status: New → In Progress
Revision history for this message
katari manoj kumar (katarimanojkumar) wrote :
Revision history for this message
katari manoj kumar (katarimanojkumar) wrote :

This change is made to avoid unnecessary CLI calls that reduces the performance during bulk operations
My customer has negative impact due to these performance issues.
With this bugfix, time taken by group snapshot/clone operation for 100 volumes reduced by 25 secs.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/745470
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=efe9dfb685321a4dfa8d3444f3a88a554b826a00
Submitter: Zuul
Branch: master

commit efe9dfb685321a4dfa8d3444f3a88a554b826a00
Author: katarimanojkumar <email address hidden>
Date: Sun Aug 9 17:39:09 2020 +0000

    [storwize]:Fixed check_flashcopy_rate issues

    Fixed issues in check_flashcopy_rate that impacts the performance
    during bulk Group Snapshot/Clone operations.

    check_flashcopy_rate will not make lssystem calls everytime,
    instead it uses code_level.

    closes bug: #1890586

    Change-Id: Icae65dd2473340450c1ff4135f1da86a884ea545

Changed in cinder:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.