MAAS

Modify maas-run-remote-scripts to interfact with udev directly

Bug #1888021 reported by Lee Trager
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Lee Trager
MAAS 2.9.0b1
2.7
Triaged
High
Lee Trager
MAAS 2.7.4b1
2.8
Fix Released
High
Björn Tillenius
MAAS 2.8.2rc1

Bug Description

When hardware testing was implemented MAAS retrieved all storage information from lsblk. Like Curtin, maas-run-remote-scripts uses lsblk to map storage device models/serials to a block device. MAAS 2.7 changed to collecting hardware information from LXD. This caused mismatches to happen due to LXD first getting storage model names from /sys than the unencoded model from udev(LP:1869116). I patched LXD to provide the encoded model from udev to match lsblk which fixed LP:1869116 on Xenial and Bionic. I am still seeing the same bug in Focal though.

maas-run-remote-scripts should stop parsing lsblk and instead gather storage information directly from udev. It should then try to map storage devices to block devices using ID_MODEL or ID_MODEL_ENC.

Related branches

~bjornt/maas:bug-1888021-2.8
MAAS Lander: Needs Fixing
Björn Tillenius: Approve
Diff: 303 lines (+129/-18)
3 files modified
src/machine-resources/src/machine-resources/Gopkg.lock (+3/-3)
src/metadataserver/user_data/templates/snippets/maas_run_remote_scripts.py (+55/-5)
src/metadataserver/user_data/templates/snippets/tests/test_maas_run_remote_scripts.py (+71/-10)
~ltrager/maas:lp1888021
Alberto Donato (community): Approve
MAAS Lander: Approve
Diff: 303 lines (+129/-18)
3 files modified
src/machine-resources/src/machine-resources/Gopkg.lock (+3/-3)
src/metadataserver/user_data/templates/snippets/maas_run_remote_scripts.py (+55/-5)
src/metadataserver/user_data/templates/snippets/tests/test_maas_run_remote_scripts.py (+71/-10)
MAAS Lander (maas-lander)
Changed in maas:
status: Triaged → Fix Committed
Revision history for this message
Björn Tillenius (bjornt) wrote :

Let's make sure this this gets backported before we release the next 2.8.x or 2.7.x. The fix for bug 1869116 broke commissioning (the test portition) of the arm64 node in our CI, which is still testing with bionic.

I did a test run with this branch, and it looks like it fixes the issue.

Revision history for this message
Björn Tillenius (bjornt) wrote :

I'm backporting this to 2.8, since CI an 2.8/edge are broken.

Lee Trager (ltrager)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.