MAAS no longer handling commissioning script processing failures
Bug #1879416 reported by
Lee Trager
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Lee Trager | ||
| 2.7 |
Fix Released
|
High
|
Lee Trager | ||
Bug Description
Prior to MAAS 2.7 MAAS collected commissioning data from multiple scripts. If there was a failure processing the output of a commissioning script only that data would be missing. If a commissioning script failed to process testing wouldn't run.
MAAS 2.7+ now silently ignores commissioning failures making them look like test failures. LP:1878923 and LP:1878643 were both reported as smartctl-validate failures when they were really errors with processing 50-maas-
Commissioning script failures need to be properly reported and testing should not run if a commissioning failure is detected.
Related branches
~ltrager/maas:lp1879416_2.7
- MAAS Lander: Needs Fixing
- Lee Trager (community): Approve
-
Diff: 108 lines (+28/-18)3 files modifiedsrc/maasserver/models/tests/test_node.py (+17/-15)
src/metadataserver/models/scriptresult.py (+7/-1)
src/metadataserver/models/tests/test_scriptresult.py (+4/-2)
~ltrager/maas:lp1879416
- Björn Tillenius: Approve
- MAAS Lander: Needs Fixing
-
Diff: 124 lines (+33/-18)4 files modifiedsrc/maasserver/models/tests/test_node.py (+17/-15)
src/metadataserver/builtin_scripts/hooks.py (+5/-0)
src/metadataserver/models/scriptresult.py (+7/-1)
src/metadataserver/models/tests/test_scriptresult.py (+4/-2)
| Changed in maas: | |
| milestone: | none → 2.8.0rc1 |
| Changed in maas: | |
| assignee: | Lee Trager (ltrager) → nobody |
| status: | In Progress → New |
| importance: | High → Undecided |
| Changed in maas: | |
| assignee: | nobody → Lee Trager (ltrager) |
| importance: | Undecided → High |
| status: | New → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
