Snap Layer

Better handle failures talking to Snapstore

Bug #1869630 reported by Haw Loeung
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Livepatch Charm
Fix Released
Critical
Jeremy Lounder
Prometheus2 charm
Fix Released
Critical
Jeremy Lounder
Prometheus2 charm 20.08
Snap Layer
Fix Released
Critical
Haw Loeung

Bug Description

Hi,

As seen elsewhere (LP:1850809):

| DEBUG:root:canonical-livepatch/14 workload status is error since 2020-03-26 16:00:44+00:00
| ERROR:root:canonical-livepatch/14 failed: workload status is error

/var/log/juju/canonical-livepatch-14:

| 2020-03-26 16:00:44 DEBUG update-status error: cannot list updates: Post https://api.snapcraft.io/v2/snaps/refresh: 2020-03-26 16:00:44 DEBUG update-status Service Unavailable

I think this is the check_refresh_available(), perhaps the Snap layer could handle this better? In particular during or in an 'update-status' hook firing - ignore and continue?

Related branches

~hloeung/layer-snap:master
Stuart Bishop: Approve
Diff: 19 lines (+7/-1)
1 file modified
lib/charms/layer/snap.py (+7/-1)
Revision history for this message
Stuart Bishop (stub) wrote :

check_refresh_available() should handle the error, on failure clearing the snap.refresh-available.foo flag. Because there is no refresh available, because the snap store is unavailable.

Changed in layer-snap:
status: New → Confirmed
status: Confirmed → Triaged
importance: Undecided → Critical
Haw Loeung (hloeung)
Changed in layer-snap:
assignee: nobody → Haw Loeung (hloeung)
Haw Loeung (hloeung)
Changed in layer-snap:
status: Triaged → In Progress
Haw Loeung (hloeung)
Changed in layer-snap:
status: In Progress → Fix Released
Jeremy Lounder (jldev)
Changed in charm-canonical-livepatch:
importance: Undecided → Critical
Changed in charm-prometheus2:
importance: Undecided → Critical
Changed in charm-canonical-livepatch:
assignee: nobody → Jeremy Lounder (jldev)
Changed in charm-prometheus2:
assignee: nobody → Jeremy Lounder (jldev)
Revision history for this message
Jeremy Lounder (jldev) wrote :

Fix released to charm-canonical-livepatch, as revisions cs:~llama-charmers/canonical-livepatch-5 and cs:canonical-livepatch-37

Changed in charm-canonical-livepatch:
status: New → Fix Released
Revision history for this message
Adam Dyess (addyess) wrote :

Fix released to charm-prometheus2, as revision cs:prometheus2-18

Changed in charm-prometheus2:
status: New → Fix Released
Adam Dyess (addyess)
Changed in charm-prometheus2:
milestone: none → 20.08
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.