version-info.py isn't reliably updated on deployments
Bug #1862777 reported by
Colin Watson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson |
Bug Description
When we do a production deployment of Launchpad, version-info.py is generated by the build on carob which runs "rm -f version-info.py; make version-info.py"; but if we deploy something other than the latest commit, then version-info.py isn't updated to match, which means that we end up deploying something that refers to combo URLs for the wrong commit and thus end up with things like broken JavaScript.
Only ever deploying the tip of stable (or at least the latest commit that's been built on carob) avoids this problem, but it would be better to make things a bit more robust here.
Related branches
~cjwatson/launchpad:always-update-version-info
Merged
into
launchpad:master
- Ioana Lasc (community): Approve
-
Diff: 21 lines (+4/-1)1 file modifiedMakefile (+4/-1)
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
status: | Triaged → In Progress |
Changed in launchpad: | |
status: | In Progress → Fix Committed |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.