[networkd] EmitLLDP for ethernet nets

Bug #1862607 reported by Frank Villaro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Netplan
Fix Released
Undecided
Unassigned

Bug Description

Hi,

networkd has an option to emit LLDP messages over the interface:
       LLDP=
           Controls support for Ethernet LLDP packet reception. LLDP is a link-layer protocol commonly implemented on professional routers and bridges which announces which physical port a system is connected to, as well as other related data. Accepts a boolean or the special value "routers-only". When true, incoming LLDP packets are accepted and a database of all LLDP neighbors maintained. If "routers-only" is set only LLDP data of various types of routers is collected and LLDP data about other types of devices ignored (such as stations, telephones and others). If false, LLDP reception is disabled. Defaults to "routers-only". Use networkctl(1) to query the collected neighbor data. LLDP is only available on Ethernet links. See EmitLLDP= below for enabling LLDP packet emission from the local system.

       EmitLLDP=
           Controls support for Ethernet LLDP packet emission. Accepts a boolean parameter or the special values "nearest-bridge", "non-tpmr-bridge" and "customer-bridge". Defaults to false, which turns off LLDP packet emission. If not false, a short LLDP packet with information about the local system is sent out in regular intervals on the link. The LLDP packet will contain information about the local host name, the local machine ID (as stored in machine-id(5)) and the local interface name, as well as the pretty hostname of the system (as set in machine-info(5)). LLDP emission is only available on Ethernet links. Note that this setting passes data suitable for identification of host to the network and should thus not be enabled on untrusted networks, where such identification data should not be made available. Use this option to permit other systems to identify on which interfaces they are connected to this system. The three special values control propagation of the LLDP packets. The "nearest-bridge" setting permits propagation only to the nearest connected bridge, "non-tpmr-bridge" permits propagation across Two-Port MAC Relays, but not any other bridges, and "customer-bridge" permits propagation until a customer bridge is reached. For details about these concepts, see IEEE 802.1AB-2016[5]. Note that configuring this setting to true is equivalent to "nearest-bridge", the recommended and most restricted level of propagation. See LLDP= above for an option to enable LLDP reception.

In a entreprise context, it is very useful to have this option enabled so that the partner device (router, switch, ...) can recognise its partner.

I may be able to produce a patch for this but I only use networkd and not NetworkManager. What do you think ?

Cheers

Frank Villaro (f-ran-k)
description: updated
Revision history for this message
Frank Villaro (f-ran-k) wrote :

Here is the patch to support the emission of LLDP packets. It is networkd only as nm doesn't support this for now.

Revision history for this message
Frank Villaro (f-ran-k) wrote :

And here is the git "patch".
Cheers

Revision history for this message
Frank Villaro (f-ran-k) wrote :
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Frank! Thank you for your PR. Mirroring my question from the review here: I see you only added support for EmitLLDP. Is there a reason why you also didn't add the LLDP setting? Is is not useful?

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, so I have merged Frank's PR for adding EmitLLDP. We decided that, if needed, the LLDP setting will be added in a separate PR.

Should we re-name this bug to only mention the missing EmitLLDP functionality and close it off?

Changed in netplan:
status: New → Fix Committed
Lukas Märdian (slyon)
summary: - [networkd] LLDP + EmitLLDP for ethernet nets
+ [networkd] EmitLLDP for ethernet nets
Changed in netplan:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.