git-ubuntu

Import fails when changelog entry signoff line contains no email address

Bug #1858653 reported by Robie Basak
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-ubuntu
Triaged
Medium
Unassigned

Bug Description

pkgbinarymangler 70~lucid1 was uploaded to Debian with the following sign-off line:

 -- pitti Fri, 09 Jul 2010 12:52:42 +0100

This fails to parse and the current specification does not tell us how to convert this to an author name and email address in the corresponding generated git commit.

Revision history for this message
Robie Basak (racb) wrote :

This currently raises a ValueError. Prior to the recent refactoring, it looks like this also failed with "Cannot get commit authorship for afb98a639b396e830e317b4f07f88a67a2d2c08c" immediately followed by a sys.exit(1).

As far as I can tell this changelog line will never have worked in the past. We need to specify how it should parse and then implement it.

Revision history for this message
Bryce Harrington (bryce) wrote :

Is this just a one-off exception, or are there other packages with the same issue?

If it's one-off, would this be ok to just handle as a special case for this one instance?

OTOH, if Debian's changelog specification permits non-email changelog entries, then this may have to be adjusted in the git-ubuntu specification. I'm hoping that's not the case because checking for the email address seems like a good way to catch a variety of potential issues.

Revision history for this message
Robie Basak (racb) wrote :

Deferring because this only appears to affect the one package.

Changed in usd-importer:
status: In Progress → Triaged
importance: High → Medium
assignee: Robie Basak (racb) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.