Network Manager not saving OpenVPN password

Bug #1858092 reported by Duarte Rocha
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
NetworkManager
Fix Released
Unknown
network-manager (Ubuntu)
Fix Released
Medium
Jose Manuel Santamaria Lema
Eoan
Fix Released
Medium
Jose Manuel Santamaria Lema
Focal
Fix Released
Medium
Jose Manuel Santamaria Lema

Bug Description

[impact]

network-manager no longer correctly saves VPN passwords

[test case]

on a 19.10 (or later) system, configure a VPN with network-manager and provide a password that it should save. On next connection, it will prompt for a password again.

[regression potential]

as this adjusts how n-m handles connections with secrets/passwords, any regression would likely cause secrets to fail to be stored for later use, and/or failure to correctly use the secrets at all to setup the connection.

[scope]

This is needed only in eoan.

The patch:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/cf557bf06f344bdbcd775dce35daa42335c645d7
is included in the 1.20.6 release:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/230#note_283402

focal-proposed currently has version 1.20.8, so this patch is already included in focal.

This bug was introduced after version 1.18.2:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/230#note_235976

disco-updates has version 1.60.0, so this patch is not needed in disco or earlier.

[other info]

original description:
---

Hi everyone,

After upgrading to kubuntu 19.10 I can't save the VPN password using Store password for this user only. It seems the integration with the kwallet is failing somehow...
The system logs seem to show that everything went ok, but the password is not saved:
jan 02 11:40:40 NetworkManager[5530]: <info> [1577965240.2166] audit: op="connection-update" uuid="4c05-911a-1d9161f05a19" name="ovpn" args="vpn.secrets" pid=14142 uid=1000 result="success"

This also happens with a clean install.

Operating System: Kubuntu 19.10
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.4
Kernel Version: 5.3.0-24-generic
OS Type: 64-bit

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https://wiki.ubuntu.com/Bugs/FindRightPackage. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.

To change the source package that this bug is filed about visit https://bugs.launchpad.net/ubuntu/+bug/1858092/+editstatus and add the package name in the text box next to the word Package.

[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]

tags: added: bot-comment
Paul White (paulw2u)
affects: ubuntu → network-manager (Ubuntu)
tags: added: eoan
Changed in network-manager (Ubuntu):
status: New → Confirmed
Revision history for this message
Jose Manuel Santamaria Lema (panfaust) wrote :

This bug also affects focal, it's a network-manager bug fixed in 1.20.6 which we could patch in the packaging while we don't have the .6 package.

Attaching debdiff for focal...

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "network-manager_1.20.4-2ubuntu4.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Dan Streetman (ddstreet)
description: updated
Changed in network-manager (Ubuntu Eoan):
status: New → In Progress
Changed in network-manager (Ubuntu Focal):
status: Confirmed → In Progress
importance: Undecided → Medium
Changed in network-manager (Ubuntu Eoan):
importance: Undecided → Medium
assignee: nobody → Jose Manuel Santamaria Lema (panfaust)
Changed in network-manager (Ubuntu Focal):
assignee: nobody → Jose Manuel Santamaria Lema (panfaust)
Dan Streetman (ddstreet)
description: updated
Changed in network-manager (Ubuntu Focal):
status: In Progress → Fix Released
Changed in network-manager:
status: Unknown → Fix Released
Revision history for this message
Dan Streetman (ddstreet) wrote :

@panfaust or @duarte-rocha, can you test with the n-m from this ppa
https://launchpad.net/~ddstreet/+archive/ubuntu/lp1858092

Revision history for this message
Duarte Rocha (duarte-rocha) wrote :

@ddstreet

Network Manager works with the ppa provided.

Thanks

Revision history for this message
Dan Streetman (ddstreet) wrote :

> Network Manager works with the ppa provided.

thanks for verifying, uploaded to eoan.

Revision history for this message
Pete (pt.pete.pt) wrote :

Is there a rough timeline when this will be available in eoan?

I can confirm the bug on all my ubuntu 19.10 installs and I have to switch vpns frequently.

Thanks for the great work!

Revision history for this message
Jose Manuel Santamaria Lema (panfaust) wrote :

Hi Pete,

I will try to re-check the status of this for eoan today after work. Sorry for the delay, I have been very busy lately ;)

Cheers.

Revision history for this message
Jose Manuel Santamaria Lema (panfaust) wrote :

P.S. The bug is indeed fixed in focal.

Revision history for this message
Dan Streetman (ddstreet) wrote :

> Is there a rough timeline when this will be available in eoan?

It's been in the upload queue for Eoan since Jan 8, hopefully it will be reviewed/accepted soon.

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Duarte, or anyone else affected,

Accepted network-manager into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network-manager/1.20.4-2ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in network-manager (Ubuntu Eoan):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-eoan
Mathew Hodson (mhodson)
tags: added: regression-release
removed: kwallet manager network openvpn
Revision history for this message
Pete (pt.pete.pt) wrote :

Tested with network-manager 1.20.4-2ubuntu2.2 from proposed on eoan.

Result: VPN passwords are saved correctly again!

Thank you so much! I built a vpn benchmark script that relies on the password being able to be saved. It uses the nmcli tool to add new connections and set the password.
It can now run again.

tags: added: verification-done-eoan
removed: verification-needed-eoan
Dan Streetman (ddstreet)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Matthias Lohr (mlohr) wrote :

Tested it, too. Works now. Thanks for fixing!

Revision history for this message
Nico R (u-nico-c) wrote :

Is there an estimation when this will go from proposed to release? I'm working around it by looking up the connections' UID in the Network-Manager configuration and manually adding the corresponding entries in KWallet as of now..

Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for network-manager has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 1.20.4-2ubuntu2.2

---------------
network-manager (1.20.4-2ubuntu2.2) eoan; urgency=medium

  [ José Manuel Santamaría Lema ]
  * d/p/lp1858092-fix_updating_agent_vpn_secrets.patch:
    - fix VPN password storing (LP: #1858092)

network-manager (1.20.4-2ubuntu2.1) eoan; urgency=medium

  * d/t/killswitches-no-urfkill, d/t/urfkill-integration,
    d/t/wpa-dhclient, d/t/nm.py, d/t/control:
    - skip tests on s390 due to missing wireless kernel support
      (LP: #1855009)
    - skip tests on i386 since there is no i386 kernel anymore,
      so we can't build our custom rfkill test module
      (LP: #1855183)

 -- Dan Streetman <email address hidden> Wed, 08 Jan 2020 08:45:30 -0500

Changed in network-manager (Ubuntu Eoan):
status: Fix Committed → Fix Released
Revision history for this message
Nico R (u-nico-c) wrote :

Can confirm that, after updating from the official repositories (Kubuntu 19.10), saving passwords "for this user only" works as intended again. Thanks!

Revision history for this message
Timur Tabi (timur-tabi) wrote :

I'm running Kubuntu 20.04 (NetworkManager 1.22.10) and this problem exists. I have an openconnect VPN and despite enabling "Store passwords", the password is never stored.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.