Importer races on date_created between Debian and Ubuntu
Bug #1851361 reported by
Robie Basak
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| git-ubuntu |
Fix Released
|
Undecided
|
Robie Basak | ||
Bug Description
We currently process the Debian distribution first, and then Ubuntu later.
Whether a package is synced within Launchpad or fakesynced, it's therefore possible for us to see the future SPPH first, and end up using that date_created timestamp for the imported commit. This is a race condition that would mutate our commit hashes.
The solution is to process them in parallel, sorting by date_created together as they are processed.
Related branches
~racb/git-ubuntu:interleave-publication-dates
- Server Team CI bot: Approve (continuous-integration)
- Bryce Harrington: Approve
-
Diff: 447 lines (+300/-51)4 files modifiedgitubuntu/git_repository.py (+7/-0)
gitubuntu/importer.py (+52/-44)
gitubuntu/source_information.py (+117/-7)
gitubuntu/source_information_test.py (+124/-0)
| tags: | added: spec |
Revision history for this message
| Nish Aravamudan (nacc) wrote | #1 |
Revision history for this message
| Nish Aravamudan (nacc) wrote | #2 |
| tags: | added: import |
| Changed in usd-importer: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Robie Basak (racb) |
| Changed in usd-importer: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Robie Basak (racb) wrote Fix released in git-ubuntu | #3 |
| Changed in usd-importer: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This tickled something in my memory of a brain dump I had passed to you suggesting the same thing for purely a code reorganization reason. I think I had even created a branch, let me look. Ah yes: https:/