Weird SYSTEM dmi device names are mishandled
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox Support Library |
Fix Released
|
High
|
Jonathan Cave | ||
Bug Description
Discovered in lp:1850930
Some Lenovo systems have characters in their name that are not handled well.
For example,
Handle 0x0023, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: System x3550 M5: -[5463AC1]-
Version: 07
Serial Number: 06EEEAR
UUID: 7b75005c-
Wake-up Type: Power Switch
SKU Number: (none)
Family: System X
From that, checkbox produces
{
"system_
"system_
"system_
"system_
"system_uuid": "7b75005c-
"system_
"system_
"system_
"category": "SYSTEM"
},
Related branches
- Sylvain Pineau (community): Approve
- Sheila Miguez (community): Approve
-
Diff: 1279 lines (+1225/-2)3 files modifiedcheckbox_support/parsers/dmidecode.py (+2/-2)
checkbox_support/parsers/tests/dmidecode_data/LENOVO_SYSTEMX.txt (+1192/-0)
checkbox_support/parsers/tests/test_dmidecode.py (+31/-0)
| description: | updated |
| Sheila Miguez (codersquid) wrote | #1 |
| Changed in checkbox-support: | |
| importance: | Undecided → High |
| milestone: | none → 0.43.0 |
| Jonathan Cave (jocave) wrote | #2 |
| Jonathan Cave (jocave) wrote | #3 |
| Sylvain Pineau (sylvain-pineau) wrote | #4 |
| Changed in checkbox-support: | |
| status: | New → Fix Committed |
| status: | Fix Committed → New |
| Changed in checkbox-support: | |
| status: | New → Confirmed |
| assignee: | nobody → Jonathan Cave (jocave) |
| status: | Confirmed → In Progress |
| Changed in checkbox-support: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox-support: | |
| status: | Fix Committed → Fix Released |
Maybe change the key regex to have [^:]+ instead of .+