Ubuntu
livecd-rootfs package

Add support for EXTRA_SNAPS in bionic

Bug #1849491 reported by Łukasz Zemczak
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Łukasz Zemczak
Bionic
Fix Released
Undecided
Łukasz Zemczak

Bug Description

[Impact]

Currently we are building core18 images using devel (eoan previously, now focal), but we need to switch to actually using bionic instead (as focal will be core20). For this to happen, we need bionic to have the same EXTRA_SNAPS support as we have in eoan as the new custom-image building solution relies on this feature.

We actually might need to do the same for xenial to enable the same feature for core16.

[Test Case]

Run a livefs build of core18 using the bionic-proposed (or xenial-proposed) series and add an EXTRA_SNAPS list of snaps in the metadata override (e.g. "hello-world"). Check the logs to see if the extra snaps have been pulled into the image.

[Regression Potential]

Basically none. The only regression potential I can think of is by this change being wrongly backported and somehow causing ubuntu-core builds to fail or incorrectly pass additional arguments - but we don't actually rely on that.

See original description
Łukasz Zemczak (sil2100)
description: updated
Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
Changed in livecd-rootfs (Ubuntu Xenial):
assignee: nobody → Łukasz Zemczak (sil2100)
Changed in livecd-rootfs (Ubuntu Bionic):
assignee: nobody → Łukasz Zemczak (sil2100)
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Łukasz, or anyone else affected,

Accepted livecd-rootfs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.408.56 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Adam Conrad (adconrad) wrote :

Hello Łukasz, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.33 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Just ran a livefs build of ubuntu-core bionic with an "extra_snaps": ["hello-world"] override - the build succeeded and the extra snap has been pulled onto the image:

https://launchpadlibrarian.net/450308352/buildlog_ubuntu_bionic_amd64_ubuntu-core_BUILDING.txt.gz

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

The same seems to work for xenial as well, the test livefs build seems to include the requested extra snap:

https://launchpadlibrarian.net/450309814/buildlog_ubuntu_xenial_amd64_ubuntu-core_BUILDING.txt.gz

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.525.33

---------------
livecd-rootfs (2.525.33) bionic; urgency=medium

  * Add support for the 'kassel' subflavor of UC18 images. (LP: #1850674)

livecd-rootfs (2.525.32) bionic; urgency=medium

  * Fix a terrible typo in auto/build that causes all core18 builds to fail on
    this series (LP: #1849343).
  * Backport 999-ubuntu-image-customization.chroot to have a common place for
    our cloud-init datasource. Add some modifications on top to make sure the
    legacy raspi2 configuration stays the same (LP: #1849472).
  * Backport enabling of adding extra snaps to ubuntu-core images via the
    EXTRA_SNAPS environment (LP: #1849491).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 30 Oct 2019 18:09:02 +0100

Changed in livecd-rootfs (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.408.56

---------------
livecd-rootfs (2.408.56) xenial; urgency=medium

  * Backport enabling of adding extra snaps to ubuntu-core images via the
    EXTRA_SNAPS environment (LP: #1849491).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 30 Oct 2019 17:28:57 +0100

Changed in livecd-rootfs (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.