Ubuntu
postfix package

Update DEP8 test to python3

Bug #1845334 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
postfix (Ubuntu)
Fix Released
Undecided
Andreas Hasenack

Bug Description

The postfix dep8 tests[1][2] should be updated to python3.

Some work about this was already done in the qa-regression-testing[3][4] repository, which is where this test came from originally, so it should hopefully just be a matter of cherry-picking the needed fixes. We could also take the opportunity to update the script with new tests that have been added.

Since postfix is a sync from debian, once we know the updated tests work with py3 on both debian and ubuntu, the changes should be proposed to Debian via salsa at https://salsa.debian.org/postfix-team/postfix-dev

1. https://git.launchpad.net/ubuntu/+source/postfix/tree/debian/tests/testlib.py
2. https://git.launchpad.net/ubuntu/+source/postfix/tree/debian/tests/test-postfix.py
3. https://git.launchpad.net/qa-regression-testing/tree/scripts/testlib.py
4. https://git.launchpad.net/qa-regression-testing/tree/scripts/test-postfix.py

Revision history for this message
Scott Kitterman (kitterman) wrote :

Any word on this? It'd be nice to get it done.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I'll resume distro packaging work starting tomorrow, thanks for the ping.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Looking at this now.

Changed in postfix (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I have a pass with python3 for 3.4.7-1 in debian/sid. Let me clean that branch up now and make a MR in salsa.

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 1845334] Re: Update DEP8 test to python3

On Friday, November 1, 2019 8:59:55 AM EDT you wrote:
> I have a pass with python3 for 3.4.7-1 in debian/sid. Let me clean that
> branch up now and make a MR in salsa.
>
> ** Attachment added: "log"
>
> https://bugs.launchpad.net/ubuntu/+source/postfix/+bug/1845334/+attachment/
> 5302040/+files/log

Thanks. A patch in the BTS is fine too, whichever is easier for you.

Scott K

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Salsa MR: https://salsa.debian.org/postfix-team/postfix-dev/merge_requests/3

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package postfix - 3.4.7-2

---------------
postfix (3.4.7-2) unstable; urgency=medium

  [Andreas Hasenack]

  * Update autopkgtest to use python3. Closes: #943212 LP: #1845334

  [Scott Kitterman]

  * Update smtp_tls_CApath to /etc/ssl/certs so it actually works.
    Closes: #923083
  * Refactor running status detection in sysv init based on upstream
    postfix-script so it works in docker. Closes: #941293

 -- Scott Kitterman <email address hidden> Sun, 03 Nov 2019 13:09:50 -0500

Changed in postfix (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.