intel

[TGL] Thunderbolt support (Tiger Lake)

Bug #1844410 reported by quanxian
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
intel
Fix Released
Undecided
Unassigned
linux (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Won't Fix
Undecided
Unassigned
Groovy
Invalid
Undecided
Unassigned
linux-oem-5.6 (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Groovy
Fix Released
Undecided
Unassigned

Bug Description

[SRU Justification]

[Impact]

TigerLake platforms fail to probe thunderbolt controller and leaving an
error message:

  [ 2.069944] input: PS/2 Generic Mouse as /devices/platform/i8042/serio1/input/input5
  [ 21.772011] thunderbolt: probe of 0000:00:0d.2 failed with error -110

It also introduces a nearly 20 second idle at boot.

[Fix]

Commit 57d8df68eb53 ("thunderbolt: Add support for Intel Tiger Lake") recently landed to v5.8-rc1 addressed this issue.

[Test Case]

Check thunderbolt controller probe messages from dmesg:

  thunderbolt 0000:00:0d.2: 0: unsupported switch device id 0x9a1b
  thunderbolt 0000:00:0d.2: 0: uid crc8 mismatch (expected: 0x8e, got: 0x59)

[Regression Potential]

Low. This only enables devices which are previously failed in device
initialization.

========== Original Bug Description ==========

Description
TBT enabling in TGL

* 386e5e29d81c ("thunderbolt: Make tb_find_port() available to other files") v5.6-rc1
* 4deb200d34a7 ("thunderbolt: Call tb_eeprom_get_drom_offset() from tb_eeprom_read_n()") v5.6-rc1
* 210e9f56e9e1 ("thunderbolt: Populate PG field in hot plug acknowledgment packet") v5.6-rc1
* b04079837b20 ("thunderbolt: Add initial support for USB4") v5.6-rc1
* 690ac0d20d40 ("thunderbolt: Update Kconfig entries to USB4") v5.6-rc1
* aa43a9dcf7fc ("thunderbolt: Make tb_switch_find_cap() available to other files") v5.6-rc1
* cf29b9afb121 ("thunderbolt: Add support for Time Management Unit") v5.6-rc1
* e6f818585713 ("thunderbolt: Add support for USB 3.x tunnels") v5.6-rc1

Target Kernel: 5.6
Target Release: 20.10

See original description
Revision history for this message
quanxian (quanxian-wang) wrote :

210e9f56e9e12472741b949950f9efcebf350750 386e5e29d81cd088a1111277a18f13d571a6cea5 4deb200d34a779aa336ddcd213e39eb6104eb78a 690ac0d20d4022bb3c7d84e0e3760eb40aa8028d aa43a9dcf7fcb71f34689bc63cdfb3464d2bebbb b04079837b2094f09e145676eec4b9a56ae8a6aa cf29b9afb121494a7aa12dae6eebf81347e0313b e6f818585713efb29d54f732f41291f75046a2c7
v5.6

Changed in intel:
status: New → Fix Committed
Revision history for this message
pragyansri.pathi@intel.com (pragyan) wrote :

In Addition we will need a Firmware Connection Manager that is targeted for Kernel 5.8 (Merge window June'20)

quanxian (quanxian-wang)
Changed in intel:
status: Fix Committed → Incomplete
Rex Tsai (chihchun)
summary: - Thunderbolt support (Tiger Lake)
+ [TGL] Thunderbolt support (Tiger Lake)
tags: added: tigerlake
Revision history for this message
Kent Lin (kent-jclin) wrote :

@Pragyansri,

Is Firmware Connection Manager we need for TBT same as following one?
- [TGL] USB4 FW CM support - lp:1854238

quanxian (quanxian-wang)
description: updated
tags: added: intel-kernel-20.10
removed: intel-kernel-20.04
Changed in intel:
status: Incomplete → Fix Committed
Revision history for this message
You-Sheng Yang (vicamo) wrote :

All the commits mentioned in comment #1 has been included in v5.6-rc1, therefore already included in Ubuntu's oem-5.6 kernel. Mark FIXRELEASED.

description: updated
Changed in linux (Ubuntu):
status: New → Fix Released
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Correct: it should be WONTFIX for generic v5.4 kernel in Focal, and FIXRELEASED for linux-oem-5.6.

Changed in linux (Ubuntu):
status: Fix Released → Won't Fix
Changed in linux-oem-5.6 (Ubuntu):
status: New → Fix Released
Revision history for this message
You-Sheng Yang (vicamo) wrote :

One more necessary commit was missed. https://<email address hidden>/ "thunderbolt: Add support for Intel Tiger Lake" landed to vanilla kernel v5.8-rc1 as commit 57d8df68eb53.

Changed in linux-oem-5.6 (Ubuntu):
status: Fix Released → In Progress
Changed in linux (Ubuntu):
status: Won't Fix → In Progress
status: In Progress → Won't Fix
Changed in linux-oem-5.6 (Ubuntu Focal):
status: New → In Progress
Changed in linux-oem-5.6 (Ubuntu Groovy):
status: In Progress → Invalid
Changed in linux (Ubuntu Focal):
status: New → Won't Fix
Changed in linux (Ubuntu Groovy):
status: Won't Fix → In Progress
Changed in linux (Ubuntu):
status: Won't Fix → In Progress
You-Sheng Yang (vicamo)
tags: added: oem-priority originate-from-1872651 somerville
Revision history for this message
You-Sheng Yang (vicamo) wrote :

@quanxian, so all the commits here are already landed to mainline kernel, can we mark this issue as public?

Revision history for this message
You-Sheng Yang (vicamo) wrote :

SRU: https://lists.ubuntu.com/archives/kernel-team/2020-June/111226.html OEM-5.6/U

description: updated
quanxian (quanxian-wang)
information type: Private → Public
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.6 (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Not really working on Groovy. Waiting it being uplifted to v5.7 or v5.8 from current v5.4.

Changed in linux (Ubuntu Groovy):
status: In Progress → Confirmed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Alex Tu (alextu) wrote :

Does the #10 target to 5.6.0.1019.16 for focal?

Revision history for this message
You-Sheng Yang (vicamo) wrote :

@Alex, yes.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Verified on oem-5.6 1019, thunderbolt nvme device probed correctly.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1020.20

---------------
linux-oem-5.6 (5.6.0-1020.20) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1020.20 -proposed tracker (LP: #1886753)

  * Realtek [10ec:c82f] Subsystem [17aa:c02f] Wifi adapter not found
    (LP: #1886247)
    - SAUCE: rtw88: 8822ce: add support for device ID 0xc82f

  * [WD19TB] external DP failed with DRM error message (LP: #1886165)
    - drm/i915/tgl: Update TC DP vswing table
    - drm/i915/tgl: Implement WA_16011163337
    - SAUCE: drm/i915/bios: add intel_bios_hdmi_level_shift()
    - drm/i915/tgl: Add HBR and HBR2+ voltage swing table
    - drm/i915/dc3co: Avoid full modeset when EXITLINE needs to be changed
    - drm/i915/tgl+: Use the correct DP_TP_* register instances in MST encoders
    - drm/i915/tgl+: Fix TBT DPLL fractional divider for 38.4MHz ref clock

  * ubuntu_aufs_smoke_test failed on Focal OEM 5.6 (LP: #1879308)
    - SAUCE: fs: Enable aufs

 -- Timo Aaltonen <email address hidden> Wed, 08 Jul 2020 11:44:53 +0300

Changed in linux-oem-5.6 (Ubuntu Focal):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor)
Changed in linux-oem-5.6 (Ubuntu Groovy):
status: Invalid → Fix Released
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Already in unstable/master (v5.8).

Changed in linux (Ubuntu Groovy):
status: Confirmed → Invalid
Anthony Wong (anthonywong)
Changed in hwe-next:
status: New → Fix Released
quanxian (quanxian-wang)
Changed in intel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.