ubuntu-drivers install --gpgpu should use a DKMS fallback when no linux-modules-nvidia package is available

Bug #1843796 reported by Alberto Milone
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-drivers-common (Ubuntu)
Fix Released
High
Alberto Milone
Bionic
Fix Released
High
Alberto Milone

Bug Description

SRU Request:

[Impact]

 * Calling "ubuntu-drivers install" does not install the kernel modules when passed the "--gpgpu" argument.

While matching linux-modules-nvidia packages for the running kernel should be the default choice, we should fall back to the DKMS package when they are not available.

The cha

[Test Case]

 * Remove any currently installed nvidia drivers:
   sudo apt-get --purge remove '*nvidia*'

 * Call the ubuntu drivers tool:
   sudo ubuntu-drivers install --gpgpu

 * Restart your computer, and run the nvidia-smi package:
   sudo nvidia-smi

 * Check that the output shows the NVIDIA GPU (this is a sign that the kernel module was loaded, and is running properly).

[Regression Potential]

 * Low. Currently, users relying on the --gpgpu parameter have no NVIDIA kernel modules, which prevents them from actually using the NVIDIA GPU.
________________________
ubuntu-drivers install --gpgpu should use a DKMS fallback when no linux-modules-nvidia package is available.

Currently, we do not deal with this kind of failure i.e. when no linux-modules-nvidia package is available for the kernel in use. If no such package can be found, we need to at least attempt installing the relevant DKMS package, so that users get the required kernel modules.

Changed in ubuntu-drivers-common (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Alberto Milone (albertomilone)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-drivers-common - 1:0.7.6

---------------
ubuntu-drivers-common (1:0.7.6) eoan; urgency=medium

  [ Alberto Milone ]
  * gpu-manager.c:
    - Drop prime_is_action_on() (now that it isn't on/off any more)
      and update the description.
  * UbuntuDrivers/detect.py,
    UbuntuDrivers/kerneldetection.py,
    tests/ubuntu_drivers.py,
    ubuntu-drivers:
    - Provide DKMS fallback for the "install --gpgpu" case
      when no linux-modules-nvidia are available for the driver
      and for a specific kernel (LP: #1843796).
      We have new tests to cover this scenario now.
    - Show provider of kernel modules in list --gpgpu
    - Fix linux metapackage detection.
      This was meant to be driven by the latest kernel version
      But it was only partially implemented.
      Complete the implementation and update the relevant tests.

  [ Daniel Dadap ]
  * gpu-manager.c:
    - Enable power management in NVIDIA on-demand mode:
      The NVIDIA driver can suspend the GPU when it's being used as a
      PRIME render offload source and it isn't actively being used.
      disable_power_management() sets the NVIDIA GPU's power/control
      mode to "on", which prevents the GPU from suspending when it
      might otherwise be possible to do so.
    - Increase string storage on stack for path names. This fixes
      the warnings that gcc emits when building up path names.

 -- Alberto Milone <email address hidden> Fri, 13 Sep 2019 12:38:45 +0200

Changed in ubuntu-drivers-common (Ubuntu):
status: In Progress → Fix Released
Changed in ubuntu-drivers-common (Ubuntu Bionic):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Alberto Milone (albertomilone)
Revision history for this message
Steve Langasek (vorlon) wrote :

This bug description doesn't fit the SRU template; please fix?

Changed in ubuntu-drivers-common (Ubuntu Bionic):
status: In Progress → Incomplete
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Proposed package upload rejected

An upload of ubuntu-drivers-common to bionic-proposed has been rejected from the upload queue for the following reason: "Includes a bunch of (hopefully!) non-functional whitespace changes. Changelog links to LP:# 1819207, marked as Won't Fix, and doesn't match the description in the changelog.".

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Alberto, or anyone else affected,

Accepted ubuntu-drivers-common into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-drivers-common/1:0.5.2.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-drivers-common (Ubuntu Bionic):
status: Incomplete → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Pat Viafore (patviafore) wrote :

I have tested this package in bionic-proposed, and all of my test cases passed.

Tests cases:

Testing NVIDIA drivers install on non-GPU instance does nothing
Testing NVIDIA drivers install on GPU instance
Specifying different versions for NVIDIA drivers install

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-drivers-common - 1:0.5.2.4

---------------
ubuntu-drivers-common (1:0.5.2.4) bionic; urgency=medium

  [ Alberto Milone ]
  * UbuntuDrivers/detect.py,
    UbuntuDrivers/kerneldetection.py,
    tests/ubuntu_drivers.py,
    ubuntu-drivers:
    - Provide DKMS fallback for the "install --gpgpu" case
      when no linux-modules-nvidia are available for the driver
      and for a specific kernel (LP: #1843796).
      We have new tests to cover this scenario now.
    - Show provider of kernel modules in list --gpgpu
    - Fix linux metapackage detection.
      This was meant to be driven by the latest kernel version
      But it was only partially implemented.
      Complete the implementation and update the relevant tests.
    - Make sure to install the linux-modules-nvidia package for the
      kernel flavour in use, when passing the --gpgpu argument, so
      that we can deliver a working NVIDIA installation, provided
      that the EULA was accepted.

  [ Jean-Baptiste Lallement ]
  * ubuntu-drivers,
    UbuntuDrivers/detect.py,
    tests/ubuntu_drivers.py:
    - Add a --free-only parameter, so as to allow installing only the
     available free drivers. This is a backport of only the
     ubuntu-drivers-common specific part of LP: #1819207, since
     it is tied to the rest of the changes to the test suite.
    - Add support for testing against a fake archive with free and
      non-free components.
    - Add static code checker.
  * debian/control:
    - Add pycodestyle and pyflake8 to build depends.

 -- Alberto Milone <email address hidden> Tue, 17 Sep 2019 16:34:56 +0200

Changed in ubuntu-drivers-common (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for ubuntu-drivers-common has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.