FTBFS of libvirt in Xenial

Bug #1843674 reported by Christian Ehrhardt 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libvirt (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Won't Fix
Undecided
Matthew Ruffell

Bug Description

[Impact]

 * libvirt became FTBFS in xenial due to other changes. Most likely a
   newer deboostrap that was used.

 * The fix just modifies the self-tests (not the active code that runs in
   an ubuntu users env)

 * The change is already active in Ubuntu in later releases via https://salsa.debian.org/libvirt-team/libvirt/commit/2be70b3
https://salsa.debian.org/libvirt-team/libvirt/commit/7baa0daf
https://salsa.debian.org/libvirt-team/libvirt/commit/0ce5eb75

[Test Case]

 * Build libvirt in Xenial on LP infra and while doing so do not trigger
   test fails in test-openpty and test-posix_openpt

[Regression Potential]

 * Since we only change self-test code that runs at build time the runtime
   should show now
   regressions. The one thing I can think of is that a rebuild could
   always change something
   (even a no change rebuild) but since we want to bundle it with other
   SRUs there would be a
   rebuild anyway - hence I'd think this has no regression risk of its
   own.

[Other Info]

 * This should not be fixed standalone but bundled with some other SRU to avoid useless rebuilds
   - and even more so - users downloading updates for now gain.

---

Due to a unknown other update libvirt became an FTBFS in Xenial.

The issue shows up at build on launchpad infra and has two seld-tests broken.
From the build log:
FAIL: test-openpty
==================

openpty returned -1
FAIL test-openpty (exit status: 1)

FAIL: test-posix_openpt
=======================

../../../../gnulib/tests/test-posix_openpt.c:52: assertion '0 <= master' failed
FAIL test-posix_openpt (exit status: 134)

This is somewhat familiar to bug 1641615 but showing up again in Xenial now for yet unknown reasons.

The later re-occurrence of this outside of Xenial was later on fixed by [1] for good.
Probably now triggering by some SRu of a lib into Xenial (or unlikely some change in the builder setup).
We want to add that to Xenial as well to have it build fine again.

[1]: https://salsa.debian.org/libvirt-team/libvirt/commit/2be70b3

Tags: ftbfs
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The fix does apply but not work as-is:

../../../../gnulib/tests/test-openpty.c: In function 'main':
../../../../gnulib/tests/test-openpty.c:47:24: error: 'ENENT' undeclared (first use in this function)
           if (errno != ENENT) {
                        ^
../../../../gnulib/tests/test-openpty.c:47:24: note: each undeclared identifier is reported only once for each function it appears in

Diving into sbuild env to check what we could do ...

Changed in libvirt (Ubuntu):
status: New → Fix Released
description: updated
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

@Mruffel - this is now working again with the changes discussed on IRC.
I have nothing in the pipe for Xenial atm so please combine that with your upload that you are working on.

Pick the changes needed from my repo at:
https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+ref/bug-1843674-FTBFS-xenial-pty

Assigning the bug to you then.

In case there is an earlier upload by me (or e.g. security) we can pick the changes into ours to get it building and you can drop it from yours.

Changed in libvirt (Ubuntu Xenial):
assignee: nobody → Matthew Ruffell (mruffell)
tags: added: ftbfs
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

There's a fix for openpty() issues on Xenial livecd-rootfs in LP bug 1844504.
These changes may not actually be required with that, but they seem to harm anyway.

Hope this helps,
Mauricio

Revision history for this message
Matthew Ruffell (mruffell) wrote :

This has now been resolved by Bug 1844504, mentioned above by Mauricio. Since the patches to fix the pty issues are no longer needed, I will not SRU them.

Thanks for your help Christian and Mauricio.

Successful build log of a new libvirt test package, dated today:

https://launchpad.net/~mruffell/+archive/ubuntu/sf242822-test/+build/18001022/+files/buildlog_ubuntu-xenial-amd64.libvirt_1.3.1-1ubuntu10.28+sf242822v20191031b1_BUILDING.txt.gz

Changed in libvirt (Ubuntu Xenial):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.