503s from https://api.launchpad.net/devel/%7Eubuntumembers/participants
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Colin Watson | ||
Bug Description
This is happening fairly reliably, and started this morning. A few examples:
* https:/
* https:/
* https:/
The code that is causing this:
def users_in_
"""Determine whether any of these users are in the supplied team.
:param users: The users which may be members of the supplied team.
:param team: The team which users may be part of.
:return: True if any of the users are members of the team, otherwise
False.
"""
for member in team.participants:
if member in users:
return True
else:
return False
Related branches
- William Grant: Approve (code)
-
Diff: 118 lines (+40/-28)2 files modifiedlib/lp/registry/model/person.py (+9/-1)
lib/lp/registry/tests/test_person.py (+31/-27)
| Dan Watkins (oddbloke) wrote | #1 |
| Paride Legovini (paride) wrote | #2 |
| Colin Watson (cjwatson) wrote | #3 |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| importance: | Undecided → Critical |
| status: | New → In Progress |
| tags: | added: api lp-registry oops |
| Launchpad QA Bot (lpqabot) wrote | #4 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
We run jobs that use this code fairly regularly (we have 4 jobs that run on a 15 minute interval), and we started seeing these failures reliably at 11:34Z today.