LVM: fix missing dash
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
resource-agents (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Invalid
|
Medium
|
Unassigned | ||
Bionic |
Fix Released
|
Medium
|
Eric Desrochers |
Bug Description
[Impact]
lvm-tag.sh line 150 is missing a dash in front of 'aly' flags. This is causing lvm resource to fail during start.
heartbeat/
vgchange_
is missing a - in front of aly. The - can be seen in the deactivate line:
vgchange_
Upstream fix:
https:/
Version: 1:4.1.0~
[Test Case]
It's the ocf:heartbeat:LVM resource that fails here (because the flags it passes to vgchange to activate the VG are incorrect). It manages an Linux Volume Manager volume (LVM) as an HA resource.
[Potential Regression]
I don't expect regression, the missing "-" need to be there to properly perform the activation. Once the activation will work using the "-", it's not impossible that one finds other corner situation due to the fact that the activation now working, but IMHO they'll be consider bugs, not regression to this SRU.
[Other Infos]
* Redhat Bug:
https:/
* Upstream fix:
https:/
$ git describe --contains 5a664525a20d3d5
v4.2.0rc1~42^2
$ rmadison resource-agents
resource-agents | 1:3.9.7-1ubuntu1.1 | xenial-updates # lvm-tag.sh doesn't exist yet.
=> resource-agents | 1:4.1.0~
resource-agents | 1:4.2.0-1ubuntu1.1 | disco-updates
resource-agents | 1:4.2.0-1ubuntu2 | eoan
tags: | added: sts |
description: | updated |
Changed in resource-agents (Ubuntu): | |
status: | New → Fix Released |
Changed in resource-agents (Ubuntu Bionic): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Eric Desrochers (slashd) |
Changed in resource-agents (Ubuntu Xenial): | |
assignee: | nobody → Eric Desrochers (slashd) |
importance: | Undecided → Medium |
Changed in resource-agents (Ubuntu Xenial): | |
status: | New → In Progress |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
Changed in resource-agents (Ubuntu Xenial): | |
status: | In Progress → Invalid |
description: | updated |
Changed in resource-agents (Ubuntu Xenial): | |
assignee: | Eric Desrochers (slashd) → nobody |
lvm-tag.sh doesn't exist in Xenial, and I couldn't find any equivalent missing dash in Xenial.
The only place I found similar pattern is inside "heartbeat/LVM" and everything looks good to me at first glance.
#heartbeat/LVM options( )
get_activate_
{
local options="-a"
case $(get_vg_mode) in "${options} ly";; "${options} y --config activation{ volume_ list=[\ "@${OUR_ TAG}\"] }";; "${options} ey";;
0) options=
1) options=
2) options=
esac