dkimpy

From header is not included error

Bug #1838262 reported by Gowtham
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dkimpy
Fix Released
High
Scott Kitterman
dkimpy 0.9.3

Bug Description

During ARC signing, on `dkim/arcsign.py` file an error is being thrown here:

`

sig = dkim.arc_sign(message, selector, domain, open(privatekeyfile, "rb").read(),
                   srv_id, cv, dkim.util.get_linesep(message))

`

where the last parameter is clearly meant as a line separator parameter, but the `arc_sign` method is expecting `include_headers` at that place. Prepending `linesep` seems to solve the issue. I have attached the patch.

See original description
Revision history for this message
Gowtham (gowthamgts12) wrote :
description: updated
Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 1838262] [NEW] From header is not included error

What version of Ubuntu/dkimpy do you have?

Scott K

Revision history for this message
Gowtham (gowthamgts12) wrote :

I'm on mac with the latest 0.9.2 of dkimpy. Tested with python 2.7.10

Revision history for this message
Scott Kitterman (kitterman) wrote :

Thanks. I misread that as being against the Ubuntu package (which uses the same tracker).

Patch looks good.

Scott K

Changed in dkimpy:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Scott Kitterman (kitterman)
milestone: none → 0.9.3
Scott Kitterman (kitterman)
Changed in dkimpy:
status: In Progress → Fix Committed
Gowtham (gowthamgts12)
information type: Public → Public Security
information type: Public Security → Public
Revision history for this message
Scott Kitterman (kitterman) wrote :

2019-08-09 Version 0.9.3
    - Fix linesep setting in arcsign script (LP: #1838262) (Thanks to Gowtham
      Gopalakrishnan for the report and the patch)
    - Fix default canonicalization for DKIM signature verification to be
      simple/simple per RFC 6376 (LP: #1839299) (Thanks to Cyril Nicodème for
      the report and a suggested fix)

Changed in dkimpy:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.