Update footprint does not reset text visibilities

Bug #1836183 reported by Romain
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Jeff Young

Bug Description

In the "Update Footprints from Library" window (attached), when replacing a footprint the visibility of the text on the F.Fab layer does not change despite the box "Reset text layers and visibilities" being ticked.
I have made the Value field (on the F.Fab layer) invisible and saved the footprint, but the change is not taken into account.

Expected behaviour: if the box "Reset text layers and visibilities" is ticked, the visibility should be updated.
Actual behaviour: the visibility of the text is not updated.
Workaround: ticking the box "Reset text sizes, styles and positions" does change the visibility and resets the position of all texts.

Application: kicad
Version: (5.1.2)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew
Revision history for this message
Romain (romain145) wrote :
Revision history for this message
Jeff Young (jeyjey) wrote :

Turns out the visible bit is part of the Effects bitfield, so the value of the "Reset text sizes, styles and positions" essentially overrides the "Reset visibility" checkbox.

Changed in kicad:
status: New → In Progress
assignee: nobody → Jeff Young (jeyjey)
importance: Undecided → Medium
milestone: none → 6.0.0-rc1
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 6c9e34e799a5b79d8926039857f7751b99da901e
https://git.launchpad.net/kicad/patch/?id=6c9e34e799a5b79d8926039857f7751b99da901e

Changed in kicad:
status: In Progress → Fix Committed
tags: added: pcbnew
Jeff Young (jeyjey)
Changed in kicad:
milestone: 6.0.0-rc1 → 5.1.3
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.