Ubuntu
cloud-init package

VMware: post custom script isn't run correctly

Bug #1833192 reported by Xiaofeng Wang
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Fix Released
Undecided
Unassigned
cloud-init (Ubuntu)
Fix Released
Undecided
Xiaofeng Wang

Bug Description

In DataSouceOVF.py, it could launch the user defined script before the customization and after the customization. In current design, the post customization script is added as the rc.local service and launched after the VM reboot. But actually the cloud-init doesn't need to reboot the VM, so the post customization script is not launched as we expected. We need to leverage the cc_scripts_per_instance module and let it to trigger the post customization script.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: evince (not installed)
ProcVersionSignature: Ubuntu 4.4.0-21.37-generic 4.4.6
Uname: Linux 4.4.0-21-generic x86_64
ApportVersion: 2.20.1-0ubuntu2.18
Architecture: amd64
Date: Tue Jun 18 08:58:04 2019
InstallationDate: Installed on 2018-08-03 (319 days ago)
InstallationMedia: Ubuntu-Server 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.3)
ProcEnviron:
 TERM=linux
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: evince
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

~xiaofengw/cloud-init:xiaofengw-fix-post-script
Server Team CI bot: Approve (continuous-integration)
Ryan Harper: Approve
Diff: 363 lines (+111/-155)
3 files modified
cloudinit/sources/DataSourceOVF.py (+6/-1)
cloudinit/sources/helpers/vmware/imc/config_custom_script.py (+42/-101)
tests/unittests/test_vmware/test_custom_script.py (+63/-53)
Revision history for this message
Xiaofeng Wang (xiaofengw) wrote :
Changed in evince (Ubuntu):
assignee: nobody → Xiaofeng Wang (xiaofengw)
Revision history for this message
Xiaofeng Wang (xiaofengw) wrote :

Codes are under review: https://code.launchpad.net/~xiaofengw/cloud-init/+git/cloud-init/+merge/368902

Revision history for this message
Ryan Harper (raharper) wrote :

Wrong source package

Changed in evince (Ubuntu):
status: New → Invalid
Dan Watkins (oddbloke)
Changed in cloud-init (Ubuntu):
assignee: nobody → Xiaofeng Wang (xiaofengw)
no longer affects: evince (Ubuntu)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

This bug is fixed with commit 9c47c682 to cloud-init on branch master.
To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=9c47c682

Ryan Harper (raharper)
Changed in cloud-init:
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-init - 19.2-0ubuntu1

---------------
cloud-init (19.2-0ubuntu1) eoan; urgency=medium

  * New upstream release.
    - Release 19.2 (LP: #1836921)
    - net: add rfc3442 (classless static routes) to EphemeralDHCP
      (LP: #1821102)
    - templates/ntp.conf.debian.tmpl: fix missing newline for pools
      (LP: #1836598)
    - Support netplan renderer in Arch Linux [Conrad Hoffmann]
    - Fix typo in publicly viewable documentation. [David Medberry]
    - Add a cdrom size checker for OVF ds to ds-identify
      [Pengpeng Sun] (LP: #1806701)
    - VMWare: Trigger the post customization script via cc_scripts module.
      [Xiaofeng Wang] (LP: #1833192)
    - Cloud-init analyze module: Added ability to analyze boot events.
      [Sam Gilson]
    - Update debian eni network configuration location, retain Ubuntu setting
      [Janos Lenart]
    - net: skip bond interfaces in get_interfaces
      [Stanislav Makar] (LP: #1812857)
    - Fix a couple of issues raised by a coverity scan
    - Add missing dsname for Hetzner Cloud datasource [Markus Schade]
    - doc: indicate that netplan is default in Ubuntu now
    - azure: add region and AZ properties from imds compute location metadata
    - sysconfig: support more bonding options [Penghui Liao]
    - cloud-init-generator: use libexec path to ds-identify on redhat systems
      (LP: #1833264)
    - tools/build-on-freebsd: update to python3 [Gonéri Le Bouder]
    - Allow identification of OpenStack by Asset Tag
      [Mark T. Voelker] (LP: #1669875)
    - Fix spelling error making 'an Ubuntu' consistent. [Brian Murray]
    - run-container: centos: comment out the repo mirrorlist [Paride Legovini]
    - netplan: update netplan key mappings for gratuitous-arp (LP: #1827238)
    - freebsd: fix the name of cloudcfg VARIANT [Gonéri Le Bouder]
    - freebsd: ability to grow root file system [Gonéri Le Bouder]
    - freebsd: NoCloud data source support [Gonéri Le Bouder] (LP: #1645824)

 -- Ryan Harper <email address hidden> Wed, 17 Jul 2019 12:43:15 -0500

Changed in cloud-init (Ubuntu):
status: New → Fix Released
Revision history for this message
Pengpeng Sun (pengpengs) wrote :

Verified VMware post customization script worked fine with cloud-init 19.2-24 on Ubuntu16.04.6

Revision history for this message
James Falcon (falcojr) wrote :

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3389

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.