reconsider the metaserver loginbox
Bug #1827786 reported by
kaputtnik
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Won't Fix
|
Wishlist
|
Unassigned | ||
Bug Description
The Metaserver login box is confusing. Image: https:/
- AFAIK the Warning isn't correct anymore
- The Login box makes only sense at first access or if a user wants to login to an registered account. So, imho, the checkbox 'Login to an registered account' is useless.
Suggestion: Remove the warning and the first checkbox and place a sentence there describing how to get a registered account.
Since this would a rework of the login box, see also bug 1827856
Related branches
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box
- kaputtnik: Pending requested
-
Diff: 188 lines (+104/-2) (has conflicts)3 files modifiedsrc/ui_fsmenu/multiplayer.cc (+12/-0)
src/wui/login_box.cc (+81/-2)
src/wui/login_box.h (+11/-0)
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start
- GunChleoc: Approve
- kaputtnik (community): Approve (testing)
-
Diff: 662 lines (+258/-127)9 files modifiedsrc/network/internet_gaming.cc (+11/-0)
src/network/internet_gaming.h (+2/-0)
src/ui_basic/editbox.cc (+46/-18)
src/ui_basic/editbox.h (+10/-0)
src/ui_fsmenu/internet_lobby.cc (+3/-2)
src/ui_fsmenu/multiplayer.cc (+39/-62)
src/ui_fsmenu/multiplayer.h (+2/-2)
src/wui/login_box.cc (+136/-38)
src/wui/login_box.h (+9/-5)
| description: | updated |
| Changed in widelands: | |
| importance: | Undecided → Wishlist |
| status: | New → Confirmed |
| milestone: | none → build21-rc1 |
| assignee: | nobody → Toni Förster (stonerl) |
| Changed in widelands: | |
| assignee: | Toni Förster (stonerl) → nobody |
| status: | Confirmed → Fix Committed |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
| Changed in widelands: | |
| status: | Fix Committed → Won't Fix |
To post a comment you must log in.
We should also add a password mode to the Editbox class that will show *** instead of the actual text.