KiCad

Large net classes-list hides Net Class Memberships-frame in Board Setup

Bug #1826154 reported by Martin Andersson on 2019-04-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	KiCad	Fix Released	Low	Ian McInerney	KiCad 5.1.3

Bug Description

Application: kicad
Version: 5.1.2-f72e74a~80~ubuntu18.10.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.1 librtmp/2.3
Platform: Linux 4.18.0-17-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags:

Revision history for this message

Martin Andersson (martin-andersson) wrote on 2019-04-24:

Large net classes-list Edit (204.7 KiB, image/png)

Nick Østergaard (nickoe) on 2019-04-24

tags:	added: pcbnew ui
Changed in kicad:
milestone:	none → 5.1.3

Michael Kavanagh (michaelkavanagh) on 2019-04-24

Changed in kicad:
importance:	Undecided → Low
status:	New → Triaged

Ian McInerney (imcinerney) on 2019-07-09

Changed in kicad:
assignee:	nobody → Ian McInerney (imcinerney)
status:	Triaged → In Progress

Revision history for this message

Ian McInerney (imcinerney) wrote on 2019-07-09:

0001-pcbnew-Make-the-netlist-class-panel-usable-with-a-lo.patch Edit (240.8 KiB, text/plain)

Here is a patch that fixes this beahviour. I had to lock the size of the two sections, and manually then recompute their size when the window is updated to get this to work. I also had to wrap the sizers inside panes since sizers can't have a defined maximum size.

Revision history for this message

Seth Hillbrand (sethh) wrote on 2019-07-12:

Works nicely. Thanks Ian!

Revision history for this message

KiCad Janitor (kicad-janitor) wrote on 2019-07-12:

Fixed in revision 39954b20fe4e81a64e9a0f3b042a2547100aaad8
https://git.launchpad.net/kicad/patch/?id=39954b20fe4e81a64e9a0f3b042a2547100aaad8

Changed in kicad:
status:	In Progress → Fix Committed

Revision history for this message

Seth Hillbrand (sethh) wrote on 2019-07-12:

I should note that sometimes these wx bits have unintended platform issues, so if any MSW devs observe netclass viewing issues, we may need to re-open

Revision history for this message

Ian McInerney (imcinerney) wrote on 2019-07-12:

@Seth, are we going to wait to cherry-pick this into 5.1 until after 5.1.3 to give this time to settle in master?

Revision history for this message

Seth Hillbrand (sethh) wrote on 2019-07-12:

I'd prefer to hold off on cherry-picking until we have some confirmation that it works for all platforms. If MSW devs can confirm before the 5.1.3 release, we'll cherry-pick it back, otherwise, we'll hold it for 5.1.4

Revision history for this message

Wayne Stambaugh (stambaughw) wrote on 2019-07-12:

I'm taking a look at in on windows right now. It might take a while due to long build times on windows.
Anyone have a sample board with a large netclass list that I can use to confirm this on windows so I don't have to generate one myself?

Revision history for this message

Wayne Stambaugh (stambaughw) wrote on 2019-07-15:

I confirmed this doesn't cause any issues on windows at least with 30 netclasses. Is there any other reason not to cherry-pick this to 5.1?

Revision history for this message

Seth Hillbrand (sethh) wrote on 2019-07-15:

#10

Great. There are no string changes and minimal risk. I've cherry-picked to 5.1

KiCad Janitor (kicad-janitor) on 2019-08-19