Auto-approval script scales badly with queue size
Bug #181254 reported by
Jeroen T. Vermeulen
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
Bug Description
The auto-approval script for the translations import queue can take a long time to run as the queue gets longer.
We believe it would help to distinguish entries that have come up for auto-approval in their current state and failed, from ones that haven't gone through auto-approval yet in their current state. The auto-approver could ignore the former, and when a template is imported, entries related to that template can be put back up for auto-approval.
Related branches
lp:~jtv/launchpad/bug-181254
- Brad Crittenden (community): Approve (code)
-
Diff: 505 lines (+361/-32)4 files modifiedlib/lp/testing/factory.py (+41/-1)
lib/lp/translations/doc/translationimportqueue.txt (+1/-0)
lib/lp/translations/model/translationimportqueue.py (+75/-23)
lib/lp/translations/tests/test_autoapproval.py (+244/-8)
| Changed in rosetta: | |
| importance: | Undecided → Medium |
| Changed in rosetta: | |
| assignee: | nobody → jtv |
| milestone: | none → 1.2.1 |
| status: | New → In Progress |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in rosetta: | |
| importance: | Medium → Low |
| milestone: | 1.2.1 → none |
| status: | In Progress → New |
| Changed in rosetta: | |
| status: | New → Confirmed |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #2 |
| Changed in rosetta: | |
| importance: | Low → High |
| Changed in rosetta: | |
| assignee: | Jeroen T. Vermeulen (jtv) → nobody |
| Changed in rosetta: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| milestone: | none → 10.08 |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #3 |
| tags: | added: qa-needstesting |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We've added a database index that fixes some of the problem (and speeds up the UI a bit), extended the alert period, and depleted most of our backlog on the queue. The new state still looks like a good idea, but for now we have more urgent things to do.