[regression] Crashing with dbus.exceptions.DBusException when logind can't be started (yet)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unattended-upgrades (Ubuntu) |
Fix Released
|
Critical
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Cosmic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
* Unattended-
* Unattended-
* The fix is adding an After service dependency on systemd-logind to ensure starting u-u.service after logind at least tried to start and also changing u-u-s to start even with logind's absence.
[Test Case]
* Stop systemd-logind and make it unable to start for example by masking it:
root@bb-logind:~# ln -s /dev/null /etc/systemd/
root@bb-logind:~# systemctl daemon-reload
root@bb-logind:~# service systemd-logind stop
root@bb-logind:~# service systemd-logind status
● systemd-
Loaded: masked (/dev/null; bad)
Active: inactive (dead) since Thu 2018-12-13 13:02:44 UTC; 1s ago
Main PID: 1938 (code=killed, signal=TERM)
Status: "Processing requests..."
...
* Run u-u-s and observe it crashing in unfixed version and starting with falling back to polling logind instead taking the inhibition lock at its start:
root@bb-logind:~# /usr/share/
root@bb-logind:~# tail /var/log/
...
2018-12-13 14:30:17,600 WARNING - Could not get delay inhibitor lock
2018-12-13 14:30:17,601 DEBUG - Skip waiting for signals, starting operation now
2018-12-13 14:30:17,601 DEBUG - Starting countdown of 25.0 minutes
2018-12-13 14:30:17,602 DEBUG - Initializing apt_pkg configuration
2018-12-13 14:30:17,602 DEBUG - get_lock returned 7
2018-12-13 14:30:17,602 DEBUG - lock not taken
* Restore logind's ability to start
root@bb-logind:~# rm /etc/systemd/
root@bb-logind:~# systemctl daemon-reload
* Restart unattended-
root@bb-logind:~# service unattended-upgrades restart
root@bb-logind:~# service unattended-upgrades status
● unattended-
Loaded: loaded (/lib/systemd/
Active: active (running) since Thu 2018-12-13 14:31:43 UTC; 3s ago
Docs: man:unattended-
Main PID: 4129 (unattended-upgr)
Tasks: 2 (limit: 4915)
CGroup: /system.
└─4129 /usr/bin/python3 /usr/share/
Dec 13 14:31:43 bb-logind systemd[1]: Started Unattended Upgrades Shutdown.
root@bb-logind:~# tail /var/log/
2018-12-13 14:30:17,601 DEBUG - Starting countdown of 25.0 minutes
2018-12-13 14:30:17,602 DEBUG - Initializing apt_pkg configuration
2018-12-13 14:30:17,602 DEBUG - get_lock returned 7
2018-12-13 14:30:17,602 DEBUG - lock not taken
2018-12-13 14:31:43,595 WARNING - SIGTERM or SIGHUP received, stopping unattended-
2018-12-13 14:31:43,688 WARNING - Could not get delay inhibitor lock
2018-12-13 14:31:43,691 WARNING - Unable to monitor PrepareForShutd
2018-12-13 14:31:43,691 WARNING - Maybe systemd-logind service is not running.
2018-12-13 14:31:43,691 WARNING - Unable to monitor PrepareForShutd
2018-12-13 14:31:43,691 WARNING - To enable monitoring the PrepareForShutd
root@bb-logind:~# systemd-analyze dot | grep unattended
...
"unattended-
...
[Regression Potential]
* The change to service ordering is unlikely to cause any issue, but the graceful handling of missing logind involved a small-scale refactoring of u-u-s's code. Extensive testing did not reveal regressions in that area, but potential bugs may cause u-u.service fail to start and affect graceful shutdown of u-u the same way as detailed in [Impact].
[Original Bug Text]
The Ubuntu Error Tracker has been receiving reports about a problem regarding unattended-
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://
Also seen as:
* https:/
description: | updated |
Changed in unattended-upgrades (Ubuntu): | |
importance: | Undecided → Critical |
description: | updated |
description: | updated |
summary: |
- /usr/share/unattended-upgrades/unattended-upgrade- - shutdown:dbus.exceptions.DBusException(org.freedesktop.DBus.Error.TimedOut):activate_name_owner:get_name_owner:call_blocking:/usr/share/unattended- - upgrades/unattended-upgrade- - shutdown@373:main:__init__:get_logind_proxy:get_object:__init__:activate_name_owner:start_service_by_name:call_blocking + [regression] Crashing with dbus.exceptions.DBusException when logind + can't be started (yet) |
tags: | added: regression-update |
tags: | added: id-5c1281350678792b80fdc206 |
Hello errors.ubuntu.com, or anyone else affected,
Accepted unattended-upgrades into cosmic-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ unattended- upgrades/ 1.5ubuntu3. 18.10.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification- needed- cosmic to verification- done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- cosmic. In either case, without details of your testing we will not be able to proceed.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance for helping!
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.