Launchpad itself

Some CVE pages time out constantly

Bug #1802728 reported by Tom Reynolds
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Critical
Unassigned

Bug Description

https://launchpad.net/bugs/cve/CVE-2017-5753 times out constantly for me whether logged in or not.

Error ID: OOPS-8ed18c9dfd84817e8c4c7d4b212229bb

While it constantly fails for me, the 'ubot5' IRC bot did successfully return the page title on a single request.

Related branches

lp:~cjwatson/launchpad/buglinktarget-bulk
William Grant: Approve (code)
Diff: 125 lines (+36/-4)
5 files modified
lib/lp/bugs/browser/buglinktarget.py (+4/-0)
lib/lp/bugs/browser/tests/test_bugtask.py (+1/-1)
lib/lp/bugs/browser/tests/test_cve.py (+23/-1)
lib/lp/bugs/model/bugtask.py (+7/-1)
lib/lp/bugs/tests/test_bugsearch_conjoined.py (+1/-1)
Colin Watson (cjwatson)
tags: added: cves lp-bugs oops timeout
Changed in launchpad:
status: New → Triaged
importance: Undecided → Critical
Colin Watson (cjwatson)
Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r18823 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18823>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

It's a bit hard to tell whether that patch has made much difference since staging is sufficiently much slower than production to obscure any gains, but it at least doesn't seem to have made matters any worse. We'll see once it's on production.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

Well, it's faster, but not fast enough: it's still timing out. A current OOPS is OOPS-88ba1d4284215d4813e0f7e59c73983e. In that, it takes rather more than five seconds between the query in the bugtask_set.getBugTaskPeople call in BugLinksListingView.buglinks and the next database query, which is an authentication check on a person. It's hard to tell how much of that is the cost of materialising the list of Person rows and how much is other stuff in between. (Also the authentication check may be a problem in itself, though I can't be sure about that.)

I think we probably need to make sure that the whole list is batched, rather than just batching the individual lists of tasks for each bug.

Changed in launchpad:
status: Fix Committed → Triaged
assignee: Colin Watson (cjwatson) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.