[2.5] Stale WebSocket connections do not automatically reconnect
Bug #1802325 reported by
Mark Shuttleworth
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Mike Pontillo |
Bug Description
Am unable to add a device from the Devices listing; clicking the "Add Device" button does nothing.
Related branches
~mpontillo/maas:enable-ping--js--bug-1802325
Merged
into
maas:master
- Blake Rouse (community): Approve
- MAAS Lander: Approve
-
Diff: 978 lines (+394/-174)11 files modified.gitattributes (+5/-0)
src/maasserver/static/js/angular/directives/tests/test_boot_images.js (+5/-0)
src/maasserver/static/js/angular/directives/tests/test_ipranges.js (+4/-0)
src/maasserver/static/js/angular/directives/tests/test_notifications.js (+5/-1)
src/maasserver/static/js/angular/directives/tests/test_pod_parameters.js (+4/-0)
src/maasserver/static/js/angular/directives/tests/test_ssh_keys.js (+4/-0)
src/maasserver/static/js/angular/factories/region.js (+232/-123)
src/maasserver/static/js/angular/factories/tests/test_region.js (+101/-41)
src/maasserver/static/js/angular/services/log.js (+1/-1)
src/maasserver/static/js/angular/testing/websocket.js (+32/-8)
webpack.config.js (+1/-0)
~mpontillo/maas:add-websocket-ping-ability--bug-1802325
Merged
into
maas:master
- Blake Rouse (community): Approve
- Newell Jensen (community): Approve
- MAAS Lander: Approve
-
Diff: 120 lines (+40/-6)2 files modifiedsrc/maasserver/websockets/protocol.py (+18/-5)
src/maasserver/websockets/tests/test_protocol.py (+22/-1)
Changed in maas: | |
status: | New → Triaged |
importance: | Undecided → Critical |
milestone: | none → 2.5.0rc1 |
tags: | added: ui |
summary: |
- [2.5b4] Add device button doesn't work + [2.5] Stale WebSocket connections do not automatically reconnect |
Changed in maas: | |
assignee: | nobody → Mike Pontillo (mpontillo) |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
milestone: | 2.5.0rc1 → 2.5.0rc2 |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I can't seem to replicate the issue. On beta4 I can add a device fine although the form could do with some love.
Does the Add device panel not open for you? What browser are you using?