[Impact]
* A recent bump to the version of wireshark in Bionic (for CVEs) has
broken the libvirt build.
* Later releases are fine, but the one in Bionic needs a fix which is
intended to be bundled with whatever the next SRU will be.
* Formerly b-deps were
libvirt -> wireshark-dev -> wiretap-dev
wireshark-dev dropped that dependency, so now libvirt needs to get the
b-dep added explicitly.
[Test Case]
* Build libvirt in Bionic
[Regression Potential]
* unexpected build issues in odd non Ubuntu-archive environments when
rebuilding the package? Sorry here I can't really think of a huge
regression (I mean by the libvirt change - the new version of wireshark
is a different story but can't be helped here and already
decided/happened)
[Other Info]
* n/a
---
Libvirt atm Fails to build from source in Bionic.
Fails to find wiretap/wtap., but actual path is <wireshark/wiretap/wtap.h>
Failing build log in sbuild: http://paste.ubuntu.com/p/T95BFDhNGJ/
Latest successful build of libvirt isn't to long ago at 2018-09-13.
But since then wireshark got bumped on 2018-10-15
Wireshark was on release at
2.4.5-1
and that is true even for the last libvirt rebuild.
It seems there were a bunch of CVEs against wireshark which made people push the much newer 2.6 series to Bionic recently.
It is now at 2.6.3-1~ubuntu18.04.1
gcc -DHAVE_CONFIG_H -I. -I../../../tools -I.. -I../include -I../../../include -I../gnulib/lib -I../../../gnulib/lib -I../src -I../../../src -I../../../src/util -I../../.. -fno-common -W -Waddress -Waggressive-loop-optimizations -Wall -Wattributes -Wbad-function-cast -Wbool-compare -Wbool-operation -Wbuiltin-declaration-mismatch -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wchkp -Wclobbered -Wcomment -Wcomments -Wcoverage-mismatch -Wcpp -Wdangling-else -Wdate-time -Wdeprecated-declarations -Wdesignated-init -Wdiscarded-array-qualifiers -Wdiscarded-qualifiers -Wdiv-by-zero -Wdouble-promotion -Wduplicated-cond -Wduplicate-decl-specifier -Wempty-body -Wendif-labels -Wexpansion-to-defined -Wextra -Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k -Wformat-zero-length -Wframe-address -Wfree-nonheap-object -Whsa -Wignored-attributes -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Wincompatible-pointer-types -Winit-self -Winline -Wint-conversion -Wint-in-bool-context -Wint-to-pointer-cast -Winvalid-memory-model -Winvalid-pch -Wjump-misses-init -Wlogical-not-parentheses -Wlogical-op -Wmain -Wmaybe-uninitialized -Wmemset-elt-size -Wmemset-transposed-args -Wmisleading-indentation -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-parameter-type -Wmissing-prototypes -Wmultichar -Wnarrowing -Wnested-externs -Wnonnull -Wnonnull-compare -Wnull-dereference -Wodr -Wold-style-declaration -Wold-style-definition -Wopenmp-simd -Woverflow -Woverride-init -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-compare -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wpsabi -Wrestrict -Wreturn-local-addr -Wreturn-type -Wscalar-storage-order -Wsequence-point -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-value -Wsizeof-array-argument -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes -Wsuggest-attribute=const -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wsuggest-attribute=pure -Wsuggest-final-methods -Wsuggest-final-types -Wswitch -Wswitch-bool -Wswitch-unreachable -Wsync-nand -Wtautological-compare -Wtrampolines -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-local-typedefs -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvarargs -Wvariadic-macros -Wvector-operation-performance -Wvolatile-register-var -Wwrite-strings -Walloc-size-larger-than=9223372036854775807 -Warray-bounds=2 -Wformat-overflow=2 -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wnormalized=nfc -Wshift-overflow=2 -Wstringop-overflow=2 -Wunused-const-variable=2 -Wvla-larger-than=4031 -Wno-sign-compare -Wjump-misses-init -Wno-format-nonliteral -Wno-format-truncation -fstack-protector-strong -fexceptions -fasynchronous-unwind-tables -fipa-pure-const -Wno-suggest-attribute=pure -Wno-suggest-attribute=const -Wframe-larger-than=4096 -fPIE -DPIE -I/usr/include/libxml2 -D_FUNCTION_DEF -g -O2 -c -o virsh-virsh-snapshot.o `test -f 'virsh-snapshot.c' || echo '../../../tools/'`virsh-snapshot.c
make[4]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/tools'
make[4]: Entering directory '/<<PKGBUILDDIR>>/debian/build/tools'
/bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../tools -I.. -I../include -I../../../include -I../gnulib/lib -I../../../gnulib/lib -I../src -I../../../src -I../../../src/util -I../../.. -I wireshark/src -pthread -I/usr/include/wireshark -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -c -o wireshark/src/wireshark_src_libvirt_la-packet-libvirt.lo `test -f 'wireshark/src/packet-libvirt.c' || echo '../../../tools/'`wireshark/src/packet-libvirt.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../tools -I.. -I../include -I../../../include -I../gnulib/lib -I../../../gnulib/lib -I../src -I../../../src -I../../../src/util -I../../.. -I wireshark/src -pthread -I/usr/include/wireshark -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -c ../../../tools/wireshark/src/packet-libvirt.c -fPIC -DPIC -o wireshark/src/.libs/wireshark_src_libvirt_la-packet-libvirt.o
In file included from /usr/include/wireshark/epan/packet_info.h:14:0,
from /usr/include/wireshark/epan/proto.h:38,
from ../../../tools/wireshark/src/packet-libvirt.c:27:
/usr/include/wireshark/epan/frame_data.h:22:10: fatal error: wiretap/wtap.h: No such file or directory
Adding "Balint Reczey" to be aware as he worked on the wireshark update - it could have broken more than just libvirt.
Also tagging regression-update (for the wireshark update).