Fix cleaning of web-download image import in node_staging_uri
Bug #1795950 reported by
Victor Coutellier
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
Fix Released
|
Undecided
|
Victor Coutellier |
Bug Description
If glance api import flow fail before reaching the end of the import via web-download, it never execute the _DeleteFromFS task and keep the file in the node_staging_uri directory on the API node.
So after many fail import, node_staging_uri is never cleaned up.
The solution will be to implement the revert() function of the _WebDownload task in order to remove the temporary file.
Changed in glance: | |
assignee: | nobody → Victor Coutellier (alistarle) |
status: | New → Fix Committed |
To post a comment you must log in.
Reviewed: https:/ /review. opendev. org/607680 /git.openstack. org/cgit/ openstack/ glance/ commit/ ?id=922c2ed5adb fedba1732417436 9cfa2329e999ab
Committed: https:/
Submitter: Zuul
Branch: master
commit 922c2ed5adbfedb a17324174369cfa 2329e999ab
Author: Victor Coutellier <email address hidden>
Date: Wed Oct 3 20:09:17 2018 +0200
Fix cleaning of web-download image import
If import flow fail before reaching the end it never execute
the _DeleteFromFS task and the node_staging_uri is never cleaned up.
Implement the revert() function of the _WebDownload task to remove the
temporary file.
Change-Id: I6dd6a6e2a95a5b d17a80b6256852b b9fac5fa339
Co-Authored-By: Grégoire Unbekandt <email address hidden>
Co-Authored-By: Abhishek Kekane <email address hidden>
Closes-Bug: #1795950