upload golang-1.10 1.10.4 to all supported releases of ubuntu

Bug #1794395 reported by Michael Hudson-Doyle
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
golang-1.10 (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[impact]
To enable packages that are backported wholesale to all releases of Ubuntu (i.e. snapd) to stop depending on what is now a fairly ancient version of Go, we are going to upload 1.10 (the version of Go in 18.04 LTS) to xenial and trusty as well. This is an unusual "SRU" but the plan has been concocted with the approval of the Ubuntu security team (who I will ask to comment here to confirm their acceptance of the plan).

[test case]
A smoke test, like this:

$ apt install golang-1.10-go
$ PATH=/usr/lib/go-1.10/bin:$PATH
$ go version
< check it's 1.10 >
$ cat > trivial.go
package main
func main() {}
$ go run trivial.go
$ cat > trivialcgo.go
package main
import "C"
func main() {}
$ go run trivialcgo.go

Then we should verify that snapd builds with the golang-1.10 in proposed take the snapd packaging for each distro series, edit this line in debian/rules:

export PATH:=/usr/lib/go-1.6/bin:${PATH}

to reference go-1.10 instead, edit the build-dependencies, and upload that to a PPA that has proposed enabled and check it builds everywhere.

[regression potential]
It's a new package so should not impact any existing behaviour. I'm not at all proposing to update the default version of Go in a stable release.

Changed in golang-1.10 (Ubuntu):
status: New → Fix Released
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I have test builds here https://launchpad.net/~mwhudson/+archive/ubuntu/devirt/+packages (they keep failing on intel because builder performance is so bad currently :()

tags: added: id-5baaaf69fafce02f17203cee
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This is fine with the security team (if it was a golang version that was in an interim release, that would be a different story, but we are already supporting this in bionic, so why not in earlier?).

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Seeing that for certain series this will be quite a big jump (even without switching the defaults), could I propose - as an additional test case - test-building snapd against the -proposed golang-1.10 in a PPA (i.e. with proposed enabled)? Since this is one of the reasons for having 1.10 in all supported series we might as well use this as a verification step.

Do you think it makes sense?

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Besides that the packages look okay-ish (the debdiff for xenial is bogus because the package was never in -updates) so I'd be willing to accept them. From a formal POV, if I recall correctly, we might need a technical board member to ACK the request. Poked Steve.

Revision history for this message
John Lenton (chipaca) wrote :

What can we do about architectures that need gccgo?

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Re: [Bug 1794395] Re: upload golang-1.10 1.10.4 to all supported releases of ubuntu

On Fri, 28 Sep 2018, 20:20 John Lenton, <email address hidden> wrote:

> What can we do about architectures that need gccgo?
>

To be clear, the only such architecture is powerpc on xenial.

For snapd, my understanding is having snapd there does not offer anyone
anything - there has never been a core snap published for powerpc has there?

The most pragmatic thing to do would be to remove snapd/powerpc from xenial
although I don't quite know how that would work. I guess a less nuclear
option would be to just build an empty snapd package on powerpc.

>

description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted golang-1.10 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-1.10/1.10.4-2ubuntu1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in golang-1.10 (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

snapd built successfully with the golang-1.10 from bionic-proposed here: https://launchpad.net/~mwhudson/+archive/ubuntu/devirt/+packages?field.name_filter=snapd&field.status_filter=published&field.series_filter=bionic

I ran through the smoke test as well:

mwhudson@ringil:/tmp$ PATH=/usr/lib/go-1.10/bin:$PATH
mwhudson@ringil:/tmp$ go version
go version go1.10.4 linux/amd64
mwhudson@ringil:/tmp$ cat > trivial.go
package main
func main() {}
mwhudson@ringil:/tmp$ go run trivial.go
mwhudson@ringil:/tmp$ cat > trivialcgo.go
package main
import "C"
func main() {}
mwhudson@ringil:/tmp$ go run trivialcgo.go
mwhudson@ringil:/tmp$ dpkg -l golang-1.10-go
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-================================-=====================-=====================-=====================================================================
ii golang-1.10-go 1.10.4-2ubuntu1~18.04 amd64 Go programming language compiler, linker, compiled stdlib

tags: added: verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package golang-1.10 - 1.10.4-2ubuntu1~18.04.1

---------------
golang-1.10 (1.10.4-2ubuntu1~18.04.1) bionic; urgency=medium

  * Backport to 18.04. (LP: #1794395)

 -- Michael Hudson-Doyle <email address hidden> Thu, 27 Sep 2018 09:17:18 +1200

Changed in golang-1.10 (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for golang-1.10 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted golang-1.10 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-1.10/1.10.4-2ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in golang-1.10 (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Michael, or anyone else affected,

Accepted golang-1.10 into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-1.10/1.10.4-2ubuntu1~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in golang-1.10 (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed-trusty
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Verification done on Xenial:

root@xenial:~# PATH=/usr/lib/go-1.10/bin:$PATH
root@xenial:~# go version
go version go1.10.4 linux/amd64
root@xenial:~# cat > trivial.go
package main
func main() {}
root@xenial:~# go run trivial.go
root@xenial:~# cat > trivialcgo.go
package main
import "C"
func main() {}
root@xenial:~# go run trivialcgo.go
root@xenial:~#

and https://launchpad.net/~mwhudson/+archive/ubuntu/devirt/+packages?field.name_filter=snapd&field.series_filter=xenial

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

And trusty:

root@trusty:~# PATH=/usr/lib/go-1.10/bin:$PATH
root@trusty:~# go version
go version go1.10.4 linux/amd64
root@trusty:~# cat > trivial.go
package main
func main() {}
root@trusty:~# go run trivial.go
root@trusty:~# cat > trivialcgo.go
package main
import "C"
func main() {}
root@trusty:~# go run trivialcgo.go
root@trusty:~#

and https://launchpad.net/~mwhudson/+archive/ubuntu/devirt/+packages?field.name_filter=snapd&field.series_filter=trusty (note that snapd has never built on trusty on arm64 or ppc64el)

tags: added: verification-done-trusty
removed: verification-needed verification-needed-trusty
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package golang-1.10 - 1.10.4-2ubuntu1~16.04.1

---------------
golang-1.10 (1.10.4-2ubuntu1~16.04.1) xenial; urgency=medium

  * Backport to 16.04. (LP: #1794395)

 -- Michael Hudson-Doyle <email address hidden> Thu, 27 Sep 2018 09:16:14 +1200

Changed in golang-1.10 (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package golang-1.10 - 1.10.4-2ubuntu1~14.04.1

---------------
golang-1.10 (1.10.4-2ubuntu1~14.04.1) trusty; urgency=medium

  * Backport to 14.04. (LP: #1794395)
  * Build with Go 1.6.
  * Do not run the test_shared tests on arm64.

 -- Michael Hudson-Doyle <email address hidden> Wed, 26 Sep 2018 12:41:47 +1200

Changed in golang-1.10 (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.