ubiquity FTBFS on Cosmic

Bug #1794137 reported by Jean-Baptiste Lallement
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
partconf (Ubuntu)
Fix Released
Undecided
Adam Conrad
ubiquity (Ubuntu)
Fix Released
Undecided
Adam Conrad

Bug Description

On Cosmic

make[2]: Entering directory '/tmp/src/ubiquity.new/d-i/source/partconf'
dh build
   dh_update_autotools_config
   dh_auto_configure
   debian/rules override_dh_auto_build
make[3]: Entering directory '/tmp/src/ubiquity.new/d-i/source/partconf'
/usr/bin/make small
make[4]: Entering directory '/tmp/src/ubiquity.new/d-i/source/partconf'
rm -f find-partitions mkfstab mountpoint \
        test-mkfstab *.o
cc -W -Wall -Os -Wdate-time -D_FORTIFY_SOURCE=2 -c -o util.o util.c
cc -W -Wall -Os -Wdate-time -D_FORTIFY_SOURCE=2 -c -o xasprintf.o xasprintf.c
cc -W -Wall -Os -o find-partitions -DFIND_PARTS_MAIN find-parts.c util.o xasprintf.o -lparted
find-parts.c: In function ‘is_cdrom’:
find-parts.c:129:13: warning: implicit declaration of function ‘major’ [-Wimplicit-function-declaration]
     switch (major(st.st_rdev)) {
             ^~~~~
find-parts.c:137:9: warning: implicit declaration of function ‘minor’; did you mean ‘mknod’? [-Wimplicit-function-declaration]
     if (minor(st.st_rdev) == 0) {
         ^~~~~
         mknod
/usr/bin/ld: /tmp/ccNaQKvW.o: in function `is_cdrom':
find-parts.c:(.text+0x3a): undefined reference to `major'
/usr/bin/ld: find-parts.c:(.text+0x50): undefined reference to `minor'
/usr/bin/ld: find-parts.c:(.text+0x60): undefined reference to `minor'
/usr/bin/ld: find-parts.c:(.text+0x73): undefined reference to `major'
/usr/bin/ld: find-parts.c:(.text+0x95): undefined reference to `major'
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:12: find-partitions] Error 1
make[4]: Leaving directory '/tmp/src/ubiquity.new/d-i/source/partconf'
make[3]: *** [debian/rules:16: override_dh_auto_build] Error 2
make[3]: Leaving directory '/tmp/src/ubiquity.new/d-i/source/partconf'
make[2]: *** [debian/rules:3: build] Error 2
make[2]: Leaving directory '/tmp/src/ubiquity.new/d-i/source/partconf'
make[1]: *** [Makefile:40: build] Error 1
make[1]: Leaving directory '/tmp/src/ubiquity.new/d-i'
make: *** [debian/rules:40: build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
debuild: fatal error at line 1152:
dpkg-buildpackage -rfakeroot -us -uc -ui failed

This is likely due to this change in glibc 2.28-0ubuntu1
* The macros 'major', 'minor', and 'makedev' are now only available from
  the header <sys/sysmacros.h>; not from <sys/types.h> or various other
  headers that happen to include <sys/types.h>. These macros are rarely
  used, not part of POSIX nor XSI, and their names frequently collide with
  user code; see https://sourceware.org/bugzilla/show_bug.cgi?id=19239 for
  further explanation.

ProblemType: Bug
DistroRelease: Ubuntu 18.10
Package: ubiquity (not installed)
ProcVersionSignature: Ubuntu 4.17.0-9.10-generic 4.17.17
Uname: Linux 4.17.0-9-generic x86_64
ApportVersion: 2.20.10-0ubuntu11
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Sep 24 17:22:21 2018
InstallCmdLine: file=/cdrom/preseed/ubuntu.seed boot=casper initrd=/casper/initrd.lz quiet splash -- keyboard-configuration/layoutcode=fr keyboard-configuration/variantcode=oss
InstallationDate: Installed on 2014-07-15 (1532 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: ubiquity
UpgradeStatus: Upgraded to cosmic on 2018-03-24 (184 days ago)

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
tags: added: rls-cc-incoming
Adam Conrad (adconrad)
Changed in partconf (Ubuntu):
assignee: nobody → Adam Conrad (adconrad)
Changed in ubiquity (Ubuntu):
assignee: nobody → Adam Conrad (adconrad)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package partconf - 1.50ubuntu1

---------------
partconf (1.50ubuntu1) cosmic; urgency=medium

  * Include <sys/sysmacros.h> to fix FTBFS with glibc 2.28 (LP: #1794137)

 -- Adam Conrad <email address hidden> Mon, 24 Sep 2018 10:59:36 -0600

Changed in partconf (Ubuntu):
status: New → Fix Released
tags: added: ftbfs
Adam Conrad (adconrad)
Changed in ubiquity (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 18.10.9

---------------
ubiquity (18.10.9) cosmic; urgency=medium

  * Fix ubiquity's use of regexes with escaped characters to satisfy new
    PEP8 requirements (W605).
  * tests/run-pep8: ignore W504 for now: line break rules have changed in PEP8
    but we're not adapting the code right now (too many noop changes this late
    in the release).

 -- Mathieu Trudel-Lapierre <email address hidden> Mon, 24 Sep 2018 16:10:40 -0400

Changed in ubiquity (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.