allowable comments number in pl_editor manual are wrong

Bug #1793148 reported by syl20j
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Jeff Young

Bug Description

in §4.1 of http://docs.kicad-pcb.org/5.0.0/en/pl_editor.html, %Cx = comment (x = 0 to 9 to identify the comment), but only 4 comments are available in the menu “Edit Page settings” (eeschema and pcbnew).

Correct the manual or better add the 6 missing comments in the menu to edit page settings : in effect, to comply with the ISO 7200 standard (https://en.wikipedia.org/wiki/ISO_7200), 4 comments is not enough to complete all the data fields (mandatory and optional) in the document header. The main missing (mandatory) fields are :
- Identification number
- Author
- Approval person
- Document type

for example see https://www.proficad.com/help/tb/data-fields-iso-7200.htm or http://tolerancing.net/engineering-drawing/title-block.html

Tags: pleditor
Changed in kicad:
status: New → Triaged
importance: Undecided → Low
tags: added: pleditor
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a6b7d4f7f6cc51d5ba2aed76227d2e530e4532a5
https://git.launchpad.net/kicad/patch/?id=a6b7d4f7f6cc51d5ba2aed76227d2e530e4532a5

Changed in kicad:
status: Triaged → Fix Committed
assignee: nobody → Jeff Young (jeyjey)
Jeff Young (jeyjey)
Changed in kicad:
milestone: none → 6.0.0-rc1
Revision history for this message
Seth Hillbrand (sethh) wrote :

Hi Jeff-

It looks like this commit breaks the python test class. Should we modify the python test case or add references from the old signature to the new?

Revision history for this message
Jeff Young (jeyjey) wrote :

@Seth, I think we should fix up the python test cases. Where do I find them?

Revision history for this message
Seth Hillbrand (sethh) wrote :

Sounds good. They are in qa/test.py

Revision history for this message
Jeff Young (jeyjey) wrote :

I've pushed what I think should fix them, though the test framework won't run on my machine so I can't be 100% sure.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.