errors when scanning partition table of corrupted AIX disk
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| linux (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
| Trusty |
Fix Released
|
Undecided
|
Unassigned | ||
| Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
| Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
[Impact]
* Users with disks/LUNs used for AIX operating system installations
previously, which possibly undergone overwrites/
partition table, might hit kernel failures during partition scan
of such disk/LUN, and possibly hang the system (seen with retries).
* The Linux kernel should be robust to corrupted disk data, performing
a better sanitization/checks and not failing.
* The fix are a couple of simple logic changes to make the code
of the AIX partition table parser more robust.
[Test Case]
* Run the partition scan on the (trimmed) disk image of the AIX lun.
(It's not provided here since it contains customer data), with this
command:
$ sudo losetup --find --show --partscan rlv_grkgld.1mb
* On failure, the command hangs, and messages like these are printed
to the console, depending on the kernel version (see tests below)
[ 270.506420] partition (null) (3 pp's found) is not contiguous
[ 270.597428] BUG: unable to handle kernel paging request at 0000000000001000
[ 270.599525] IP: [<ffffffff81379
* On success, the command prints a loop device name, for example:
/dev/loop0
[Regression Potential]
* Low. Both changes are simple improvements in logic.
* This affects users which mount disks/LUNs from the AIX OS;
it should only change behavior for users which relied on a
uninitialized variables to work correctly during partition
scan of those disks/LUNs which should be rare as the code
is likely to fail as we observe in this scenario.
* This has been tested on Cosmic, Bionic, Xenial, and Trusty.
[Other Info]
* Patches will be sent to the kernel-team mailing list.
Bug Description:
---------------
We've recently received a disk image from an AIX LUN that when
attached on Linux displayed errors on console, then eventually
hung the system (specially if the SCSI bus was re-scanned, and
leading to another partition scan).
Apparently the LUN was originally installed with AIX and later
exercised with some I/O stress/overwrites which caused certain
bits to be wrong in just the right way for Linux to get a NULL
pointer and invalid data.
This is the test-case used ('--partscan' is the important bit).
$ sudo losetup --show --find --partscan aix-lun.img
Since the original code is old, it affects several releases.
It's interesting to fix this on 14.04 and up, on which IBM
Power servers were initially supported (since they can run
AIX too, and possibly hit this due to an already used disk/LUN).
| Mauricio Faria de Oliveira (mfo) wrote | #1 |
| Mauricio Faria de Oliveira (mfo) wrote | #2 |
| Mauricio Faria de Oliveira (mfo) wrote | #3 |
| Mauricio Faria de Oliveira (mfo) wrote | #4 |
| Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote Missing required logs. | #5 |
| Changed in linux (Ubuntu): | |
| status: | New → Incomplete |
| Mauricio Faria de Oliveira (mfo) wrote | #6 |
| Changed in linux (Ubuntu): | |
| status: | Incomplete → Confirmed |
| Changed in linux (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | Confirmed → Triaged |
| Changed in linux (Ubuntu): | |
| status: | Triaged → Fix Committed |
| Rohit (mprohit) wrote | #7 |
| Changed in linux (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Stefan Bader (smb) wrote | #8 |
| no longer affects: | linux (Ubuntu Precise) |
| Changed in linux (Ubuntu Bionic): | |
| status: | New → Fix Committed |
| Changed in linux (Ubuntu Xenial): | |
| status: | New → Fix Committed |
| Changed in linux (Ubuntu Trusty): | |
| status: | New → Fix Committed |
| Brad Figg (brad-figg) wrote | #9 |
| tags: | added: verification-needed-xenial |
| Brad Figg (brad-figg) wrote | #10 |
| tags: | added: verification-needed-trusty |
| Brad Figg (brad-figg) wrote | #11 |
| tags: | added: verification-needed-bionic |
| Mauricio Faria de Oliveira (mfo) wrote | #12 |
| tags: |
added: verification-done-bionic verification-done-trusty verification-done-xenial removed: verification-needed-bionic verification-needed-trusty verification-needed-xenial |
| Launchpad Janitor (janitor) wrote | #13 |
| Changed in linux (Ubuntu Xenial): | |
| status: | Fix Committed → Fix Released |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #15 |
| Changed in linux (Ubuntu Trusty): | |
| status: | Fix Committed → Fix Released |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #17 |
| Changed in linux (Ubuntu Bionic): | |
| status: | Fix Committed → Fix Released |
| tags: | added: cscc |
Test on Cosmic:
Before:
$ uname -a
Linux bionic 4.17.0-7-generic #8-Ubuntu SMP Fri Aug 3 15:55:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
$ echo 9 | sudo tee /proc/sys/
9
$ sudo losetup --find --show --partscan rlv_grkgld.1mb
<hung>
[ 37.274451] partition (null) (20 pp's found) is not contiguous
[ 37.278839] partition (null) (8 pp's found) is not contiguous
[ 37.281066] partition (null) (8 pp's found) is not contiguous
...
[ 37.330987] partition (null) (1 pp's found) is not contiguous
[ 37.334092] partition (null) (63 pp's found) is not contiguous
[ 37.336130] partition (null) (1 pp's found) is not contiguous
After:
$ uname -a
Linux bionic 4.17.0-7-generic #8+sf181954.1 SMP Wed Aug 15 13:40:48 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
$ echo 9 | sudo tee /proc/sys/
9
$ sudo losetup --find --show --partscan rlv_grkgld.1mb
/dev/loop0