Copy/paste PCB text broken in several ways

I can confirm that 'C' doesn't do a copy with either Toolset (the text layer isn't material).

I can't reproduce the "fills zones" issue in the Modern Toolset. You might need to reset your hotkeys.

With the Modern Toolset there are additional issues:

Select a PCB text item.
Right-click > Copy
Move mouse somewhere else and click.
Ctrl-V
Don't move mouse: can't see pasted text item.
Move mouse: pasted text item appears.

Select a different PCB text item.
Right-click > Copy
Move mouse somewhere else but do NOT click.
Ctrl-V
Move mouse and note that wrong text was pasted (it's the first one)

Select a different PCB text item.
Right-click > Copy
Move mouse somewhere else and CLICK.
Ctrl-V
Move mouse and note that correct text was pasted.

Application: kicad
Version: (6.0.0-rc1-dev-354-gddbf8e3ff-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.66.0
    Curl: 7.57.0
    Compiler: Clang 9.1.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

The click/not click issue is because the EDIT_TOOL goes into "pick reference point for block" mode, but this isn't terribly obvious if you're not looking at the status bar.

I don't think reference-point-copy should be the default action. Perhaps a modifier-key option?

And for modes like this, I think the Length-Tuning-Status-Box might be a better way to communicate the mode.

There's also no context menu for the mode, which means there's no visual way to cancel it (esc does work).

Ha! The not-drawing-till-you-move thing turned out to be my bug -- the ClientSelectionFilter was inadvertently clearing the selection reference, so it was getting drawn the first time at (0, 0).

Fixed in revision c91e51f688b82faff578e259d3df6bbfd1130110
https://git.launchpad.net/kicad/patch/?id=c91e51f688b82faff578e259d3df6bbfd1130110

(Note that the above bug didn't exist in 5.0, so there's nothing to merge on that front for 5.0.1.)

I've also fixed the lack of a Context Menu when running Select Anchor.

... and changed the status message to a popup (both for this and for Position Relative To's anchor picker).

This one's probably carries a bit too much risk and not enough reward for 5.0.1 so I'll leave it 5.1-only.

The remaining part appears to be due to the fix for https://bugs.launchpad.net/kicad/+bug/1749549, so I'm going to reopen that one and let this one close.

Fixed in revision 30bb9111540038c6f65dcd6ce52b9dc903c151d3
https://git.launchpad.net/kicad/patch/?id=30bb9111540038c6f65dcd6ce52b9dc903c151d3