Ubuntu
hal-info package

hal-info and rhythmbox conflict on audio_folders for PSP

Bug #178359 reported by Karol Krizka
6
Affects Status Importance Assigned to Milestone
hal-info (Ubuntu)
Fix Released
Medium
Martin Pitt
rhythmbox (Ubuntu)
Invalid
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: hal-info

I noticed that rhythmbox support PlayStation Portables, and it works pretty well. However there is one problem. Rhythmbox tells to copy the files to /MUSIC (which is correct), and then hal adds the audio_folders setting from /usr/share/hal/fdi/information/10freedesktop/10-usb-music-players.fdi which results in /MUSIC/PSP/MUSIC (which now is wrong). The best fix for this seems to be to edit /usr/share/hal/fdi/information/10freedesktop/10-usb-music-players.fdi by changing
          <append key="portable_audio_player.audio_folders" type="strlist">PSP/MUSIC/</append>
to
           <append key="portable_audio_player.audio_folders" type="strlist">MUSIC/</append>
          <append key="portable_audio_player.audio_folders" type="strlist">PSP/MUSIC/</append>

and removing the path detection code from plugins/generic-player/rb-psp-source.c

I will try to create a patch for both packages later.

Tags: patch
Revision history for this message
Karol Krizka (kkrizka) wrote :
Revision history for this message
Karol Krizka (kkrizka) wrote :

Needs this patch applied, because rhythmbox loads the HAL values after they scanned the entire PSP memory stick, which is too late. Without this fix, rhythmbox might crash.

Revision history for this message
Pedro Villavicencio (pedro) wrote :

Thanks for the report, Seb may you take a look to it ? thanks.

Changed in rhythmbox:
assignee: nobody → seb128
importance: Undecided → Low
status: New → Triaged
Changed in hal-info:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

Can you confirm that the hal FDI should really be changed that way, i. e. the folder should merely be added? You don't need to remove this line?

      <append key="portable_audio_player.audio_folders" type="strlist">PSP/MUSIC/</append>

Changed in hal-info:
status: Triaged → Incomplete
Revision history for this message
dorkdork777 (dorkdork777) wrote :

Putting it in /MUSIC would result in /MUSIC/(artist)/(album), which looks good on paper but doesn't work for the PSP, which supports only one directory level inside /MUSIC. So it would need to be /MUSIC/(artist - album) instead.

Revision history for this message
Sebastien Bacher (seb128) wrote :

do you still get this issue inhardy?

Changed in rhythmbox:
assignee: seb128 → desktop-bugs
Revision history for this message
Pedro Villavicencio (pedro) wrote :

Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for. Thanks!.

Changed in rhythmbox:
status: Triaged → Invalid
Revision history for this message
Martin Pitt (pitti) wrote :

Might get fixed in hal-info by
http://cgit.freedesktop.org/hal-info/commit/?id=98f64375617a50ffeb6a004a27d75eb87027dfb9

I'll upload this soon, please report back if it still doesn't work correctly.

Changed in hal-info:
assignee: nobody → pitti
status: Incomplete → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hal-info - 20081124-0ubuntu1

---------------
hal-info (20081124-0ubuntu1) jaunty; urgency=low

  * New upstream git snapshot.
    - Add ISCD no-name portable audio player (LP: #116860)
    - hal-info and rhythmbox conflict on audio_folders for PSP (LP: #178359)
    - Add Pantech UM175 phone (LP: #282573)
    - Add another Nokia N82 phone model (LP: #291749)
    - Add Nokia N82 music player (LP: #282957)
    - Add another Option 3G USB Modem (LP: #284961)
    - Add Sony Walkman NWZ-135F (LP: #289161)
    - Add Onda MT505UP / MF632 music player (LP: #291333)
    - Add Nokia E66 phone (LP: #294070)
    - Add Sierra Aircard 880U modem (LP: #295855)
    - Fix typo in 20-video-quirk-pm-asus.fdi (LP: #300620)
    - Add Novatel EU870D modem (LP: #301030)

 -- Martin Pitt <email address hidden> Mon, 24 Nov 2008 11:59:58 +0100

Changed in hal-info:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.