In Py3.7 async is a keyword

Bug #1781617 reported by Corey Bryant
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Corey Bryant

Bug Description

I'm working on packaging glance for rocky on ubuntu cosmic which is now at py3.7. In py3.7 "async" is a keyword, which results in issues such as:

Failed to import test module: glance.tests.unit.async.flows.plugins.test_inject_image_metadata
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 456, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
    __import__(name)
  File "/<<PKGBUILDDIR>>/glance/tests/unit/async/flows/plugins/test_inject_image_metadata.py", line 22
    import glance.async.flows.plugins.inject_image_metadata as inject_metadata
        ^
SyntaxError: invalid syntax

Here are some more examples: https://paste.ubuntu.com/p/VHdZsKRkjC/

Revision history for this message
Peter Steele (peterbss) wrote : Re: [Bug 1781617] [NEW] In Py3.7 async is a keyword

Who do I have to blow to unsubscribe to these mailings???????????
Peter Steele
<email address hidden>

> On Jul 13, 2018, at 10:58 AM, Corey Bryant <email address hidden> wrote:
>
> Public bug reported:
>
> I'm working on packaging glance for rocky on ubuntu cosmic which is now
> at py3.7. In py3.7 "async" is a keyword, which results in issues such
> as:
>
>
> Failed to import test module: glance.tests.unit.async.flows.plugins.test_inject_image_metadata
> Traceback (most recent call last):
> File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 456, in _find_test_path
> module = self._get_module_from_name(name)
> File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
> __import__(name)
> File "/<<PKGBUILDDIR>>/glance/tests/unit/async/flows/plugins/test_inject_image_metadata.py", line 22
> import glance.async.flows.plugins.inject_image_metadata as inject_metadata
> ^
> SyntaxError: invalid syntax
>
>
> Here are some more examples: https://paste.ubuntu.com/p/VHdZsKRkjC/
>
> ** Affects: glance
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to Glance.
> Matching subscriptions: peterbs
> https://bugs.launchpad.net/bugs/1781617
>
> Title:
> In Py3.7 async is a keyword
>
> Status in Glance:
> New
>
> Bug description:
> I'm working on packaging glance for rocky on ubuntu cosmic which is
> now at py3.7. In py3.7 "async" is a keyword, which results in issues
> such as:
>
>
> Failed to import test module: glance.tests.unit.async.flows.plugins.test_inject_image_metadata
> Traceback (most recent call last):
> File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 456, in _find_test_path
> module = self._get_module_from_name(name)
> File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
> __import__(name)
> File "/<<PKGBUILDDIR>>/glance/tests/unit/async/flows/plugins/test_inject_image_metadata.py", line 22
> import glance.async.flows.plugins.inject_image_metadata as inject_metadata
> ^
> SyntaxError: invalid syntax
>
>
> Here are some more examples: https://paste.ubuntu.com/p/VHdZsKRkjC/
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/glance/+bug/1781617/+subscriptions

Changed in glance:
assignee: nobody → Corey Bryant (corey.bryant)
Changed in glance:
status: New → In Progress
Revision history for this message
Corey Bryant (corey.bryant) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/582613
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=c58e5e02af76cad3967d22d14c63794c6d60456f
Submitter: Zuul
Branch: master

commit c58e5e02af76cad3967d22d14c63794c6d60456f
Author: Corey Bryant <email address hidden>
Date: Fri Jul 13 09:20:04 2018 -0400

    Rename async package to async_

    In Python 3.7, "async" is a keyword. To prevent it from
    conflicting, rename the async package to async_.

    Change-Id: I1eaf87eedb86679d9ca9323aac05f0770c33efea
    Closes-Bug: #1781617

Changed in glance:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/605709

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 18.0.0.0b1

This issue was fixed in the openstack/glance 18.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/rocky)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/605709
Reason: Not needed with the officially supported runtimes for rocky and doesn't meet our stable requirements.

Erno Kuvaja (jokke)
Changed in glance:
milestone: none → stein-1
Revision history for this message
Peter Steele (peterbss) wrote : Quick Favor?

Hey,

I just signed the petition "Wrongly Convicted, SAVEDUSTINJHIGGS​.​COM help
me change the narrative." and wanted to see if you could help by adding
your name.

Our goal is to reach 1,500,000 signatures and we need more support. You can
read more and sign the petition here:

http://chng.it/bBQfgtqHwQ

Thanks!
Peter

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.