Legacy canvas: deleting footprint text element not recorded in undo list

Bug #1781224 reported by John Beard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Low
Wayne Stambaugh

Bug Description

If you delete a footprint text element (e.g. the Fab text) this is not recorded in the undo stack.

1) Place a footprint, enable the F_Fab layer, enter legacy mode
2) Right click the fab text, and from the Text submenu, move the text
3) Right click again, and from the submenu, delete the text
4) Press the undo hotkey
5) Result: the text reappears at the original position. Expected: the text reappears at the position it was moved to in Step 2.

This is not an issue in GAL, as the text element cannot be deleted at all.

Additionally, the delete key doesn't seem to work.
Application: kicad
Version: (5.0.0-rc3-dev-2-g14ce51820), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.60.0 OpenSSL/1.1.0h zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.31.1
Platform: Linux 4.17.2-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.60.0
    Compiler: GCC 8.1.1 with C++ ABI 1012

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: legacy pcbnew
tags: added: legacy pcbnew
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

It is a bit odd that you can modify footprint elements this way only through the context menu. Using the delete tool or the delete hot button do not delete the text element so there is a different code path in play here.

Changed in kicad:
status: New → Triaged
Changed in kicad:
importance: Undecided → Low
assignee: nobody → Wayne Stambaugh (stambaughw)
milestone: none → 5.0.0
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision eaf938c7e98eb47683bd14e8c6d3c3cf271eaaec
https://git.launchpad.net/kicad/patch/?id=eaf938c7e98eb47683bd14e8c6d3c3cf271eaaec

Changed in kicad:
status: Triaged → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.