Backups panel is visible even if enable_backup is False
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Undecided
|
Edward Hope-Morley | ||
OpenStack Dashboard Charm |
Invalid
|
Undecided
|
Unassigned | ||
Ubuntu Cloud Archive |
Fix Released
|
High
|
Unassigned | ||
Queens |
Fix Released
|
High
|
Unassigned | ||
Rocky |
Fix Released
|
High
|
Unassigned | ||
horizon (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bionic |
Fix Released
|
High
|
Unassigned | ||
Cosmic |
Fix Released
|
High
|
Unassigned |
Bug Description
Hi,
Volumes - Backup panel is visible even if OPENSTACK_
Meanwhile setting enable_backup to false removes an option to create backup of a volume in the volume drop-down options. But panel with backups itself stays visible for both admins and users.
As a work-around I use the following customization script:
import horizon
from django.conf import settings
if not getattr(settings, 'OPENSTACK_
project = horizon.
backup = project.
project.
And for permanent fix I see the following decision. In openstack_
...
+L16: from django.conf import settings
...
+L21: if not getattr(settings, 'OPENSTACK_
+L22: return False
...
== SRU details for Ubuntu =
[Impact]
See above.
[Test Case]
Juju deploy openstack and manually test that backup panel is not visible if enable_backup is set to False.
[Regression Potential]
Low. The patch has landed upstream in master, stable/rocky, and stable/queens. This patch has already landed in Ubuntu rocky as well.
Changed in horizon: | |
status: | New → Confirmed |
tags: | added: sts |
Changed in charm-openstack-dashboard: | |
assignee: | nobody → Seyeong Kim (xtrusia) |
status: | New → In Progress |
Changed in horizon: | |
assignee: | nobody → Edward Hope-Morley (hopem) |
status: | Confirmed → In Progress |
Changed in horizon (Ubuntu Bionic): | |
status: | New → Triaged |
Changed in horizon (Ubuntu Cosmic): | |
status: | New → Triaged |
Changed in horizon (Ubuntu Bionic): | |
importance: | Undecided → High |
Changed in horizon (Ubuntu Cosmic): | |
importance: | Undecided → High |
Changed in horizon (Ubuntu Bionic): | |
importance: | High → Critical |
importance: | Critical → High |
Changed in charm-openstack-dashboard: | |
status: | In Progress → Invalid |
assignee: | Seyeong Kim (xtrusia) → nobody |
milestone: | 18.11 → none |
description: | updated |
description: | updated |
description: | updated |
I can confirm this behavior, it has changed between Ocata and Queens (but is still present in the latest release also)
The "Volume Backups" used to be a tab on the "Volumes" page in Ocata. In Queens it has it's own panel on the left "Backups".
The old tab respected the enable_backup flag, but the new panel does not.
The enable_backup flag still controls the "Create Backup" option appearing in the dropdown menu for each volume; so the flag is still partially in effect.