Impact
------
Users who have manually configured an xorg.conf file with nvidia enabled as a driver will be surprised to have disabled on upgrade to a new release of Ubuntu and won't have a graphical display.
Test Case
---------
If you don't have a system with nvidia hardware to upgrade this is a bit convoluted but still works.
1) Run do-release-upgrade (use -d if upgrading to disco)
2) Cancel the upgrade
3) Create an /etc/X11/xorg.conf file with a Device section listed in the original description using the nvidia driver.
4) cd to /tmp/ubuntu-release-upgrader-$TEMPNAME
5) run ./$target-release-name --frontend DistUpgradeViewText
6) Observe the Driver line is commented out of xorg.conf
When testing the release-upgrader from -proposed you'll need to use the -p switch to get the right tarball. Additionally, you'll want to add a step 4.5 where you modify xorg_fix_proprietary.py so nvidia defaults to True instead of False (line 106) this'll simulate the nvidia driver being loaded.
Regression Potential
--------------------
This just changes how xorg_fix_proprietary check for nvidia being in use and it only affects people who have an /etc/X11/xorg.conf so the impact of a regression is rather small. Additionally, the logic used to determine if nvidia in use is the same logic used in the apport package hook for all xorg packages so is well tested.
Original Description
--------------------
I upgraded my system from 17.10 to 18.04 Bionic Beaver via do-release-upgrade.
After the installation had finished, Xorg wouldn't start. I later found out that this was because the installation routine had commented out the nvidia display driver I used in the xorg.conf:
Section "Device"
Identifier "nvidia"
# Driver "nvidia"
BusID "PCI:10@0:0:0"
Option "ConstrainCursor" "off"
EndSection
As the installtion routine backuped my xorg.conf I could verify that the line hadn't been commented out before upgrading. Removing the "#" solved the problem.
ProblemType: BugDistroRelease: Ubuntu 18.04
Package: xorg 1:7.7+19ubuntu7
ProcVersionSignature: Ubuntu 4.15.0-22.24-generic 4.15.17
Uname: Linux 4.15.0-22-generic x86_64
NonfreeKernelModules: wl nvidia_modeset nvidia
.proc.driver.nvidia.gpus.0000.0a.00.0: Error: [Errno 21] Is a directory: '/proc/driver/nvidia/gpus/0000:0a:00.0'
.proc.driver.nvidia.registry: Binary: ""
.proc.driver.nvidia.version:
NVRM version: NVIDIA UNIX x86_64 Kernel Module 390.48 Thu Mar 22 00:42:57 PDT 2018
GCC version: gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
ApportVersion: 2.20.9-0ubuntu7
Architecture: amd64
BootLog: Error: [Errno 13] Permission denied: '/var/log/boot.log'
CompizPlugins: No value set for `/apps/compiz-1/general/screen0/options/active_plugins'
CompositorRunning: None
CurrentDesktop: ubuntu:GNOME
Date: Sun May 27 11:43:16 2018
DistUpgraded: 2018-05-21 10:52:35,978 DEBUG Running PostInstallScript: './xorg_fix_proprietary.py'
DistroCodename: bionic
DistroVariant: ubuntu
DkmsStatus:
bcmwl, 6.30.223.271+bdcom, 4.15.0-20-generic, x86_64: installed
bcmwl, 6.30.223.271+bdcom, 4.15.0-22-generic, x86_64: installed
nvidia, 390.48, 4.15.0-20-generic, x86_64: installed
nvidia, 390.48, 4.15.0-22-generic, x86_64: installed
EcryptfsInUse: Yes
ExtraDebuggingInterest: Yes
GraphicsCard:
Intel Corporation HD Graphics 5500 [8086:1616] (rev 09) (prog-if 00 [VGA controller])
Subsystem: Hewlett-Packard Company HD Graphics 5500 [103c:229d]
Subsystem: Hewlett-Packard Company GM108M [GeForce 840M] [103c:229d]
InstallationDate: Installed on 2017-11-02 (205 days ago)
InstallationMedia: Ubuntu 17.10 "Artful Aardvark" - Release amd64 (20171018)
MachineType: Hewlett-Packard HP ENVY 17 Notebook PC
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.15.0-22-generic root=UUID=2c76a9d7-c435-4600-abc9-2ecd10fc3001 ro quiet splash vt.handoff=1SourcePackage: xorg
UpgradeStatus: Upgraded to bionic on 2018-05-21 (6 days ago)
dmi.bios.date: 11/28/2014
dmi.bios.vendor: Insyde
dmi.bios.version: F.33
dmi.board.asset.tag: Type2 - Board Asset Tag
dmi.board.name: 229D
dmi.board.vendor: Hewlett-Packard
dmi.board.version: 78.15
dmi.chassis.type: 10
dmi.chassis.vendor: Hewlett-Packard
dmi.chassis.version: Chassis Version
dmi.modalias: dmi:bvnInsyde:bvrF.33:bd11/28/2014:svnHewlett-Packard:pnHPENVY17NotebookPC:pvr0973120000405F10000620180:rvnHewlett-Packard:rn229D:rvr78.15:cvnHewlett-Packard:ct10:cvrChassisVersion:
dmi.product.family: 103C_5335KV G=N L=CON B=HP S=ENV X=Null
dmi.product.name: HP ENVY 17 Notebook PC
dmi.product.version: 0973120000405F10000620180
dmi.sys.vendor: Hewlett-Packard
version.compiz: compiz N/A
version.libdrm2: libdrm2 2.4.91-2
version.libgl1-mesa-dri: libgl1-mesa-dri 18.0.0~rc5-1ubuntu1
version.libgl1-mesa-glx: libgl1-mesa-glx 18.0.0~rc5-1ubuntu1
version.nvidia-graphics-drivers: nvidia-graphics-drivers-* N/A
version.xserver-xorg-core: xserver-xorg-core 2:1.19.6-1ubuntu4
version.xserver-xorg-input-evdev: xserver-xorg-input-evdev N/A
version.xserver-xorg-video-ati: xserver-xorg-video-ati 1:18.0.1-1
version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.99.917+git20171229-1
version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:1.0.15-2
Status changed to 'Confirmed' because the bug affects multiple users.